Skip to content

Fix cached docs artifact upload paths#333

Merged
yuecideng merged 1 commit into
mainfrom
fix/docs-artifact-cache-paths
Jun 26, 2026
Merged

Fix cached docs artifact upload paths#333
yuecideng merged 1 commit into
mainfrom
fix/docs-artifact-cache-paths

Conversation

@yuecideng

Copy link
Copy Markdown
Contributor

Description

This PR completes the docs artifact upload fix after the merged PR still failed on _static/clipboard.min.js?v=a7894cd8.

The remaining failure came from two paths missed by the first fix:

  • restored docs cache entries could already contain invalid query-string filenames, and skipped cached versions were never normalized
  • recursive wget can preserve the GitHub Pages repository path and create build/html/EmbodiChain/v0.2.2/..., so normalization ran against build/html/v0.2.2 while the bad file lived elsewhere

This PR normalizes the whole restored build tree, promotes repo-prefixed wget output into the expected version directory, and removes empty leftover directories.

Dependencies: none

Fixes the repeated docs artifact upload failure from run 28218363303.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which improves an existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (existing functionality will not work without user modification)
  • Documentation update

Screenshots

N/A

Checklist

  • I have run the black . command to format the code base.
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Dependencies have been updated, if applicable.

Verification

  • black docs/scripts/merge_published_site.py tests/docs/conftest.py tests/docs/test_merge_published_site.py
  • black --check docs/scripts/merge_published_site.py tests/docs/conftest.py tests/docs/test_merge_published_site.py
  • pytest tests/docs -q --confcutdir=tests/docs

Normalize invalid filenames restored from the docs cache and promote wget output that preserves the GitHub Pages repository path before uploading docs artifacts.
Copilot AI review requested due to automatic review settings June 26, 2026 05:20
@yuecideng yuecideng added bug Something isn't working ci labels Jun 26, 2026
@yuecideng yuecideng merged commit 16439f1 into main Jun 26, 2026
3 of 6 checks passed
@yuecideng yuecideng deleted the fix/docs-artifact-cache-paths branch June 26, 2026 05:23

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working ci

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants