Fix cached docs artifact upload paths#333
Merged
Merged
Conversation
Normalize invalid filenames restored from the docs cache and promote wget output that preserves the GitHub Pages repository path before uploading docs artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR completes the docs artifact upload fix after the merged PR still failed on
_static/clipboard.min.js?v=a7894cd8.The remaining failure came from two paths missed by the first fix:
wgetcan preserve the GitHub Pages repository path and createbuild/html/EmbodiChain/v0.2.2/..., so normalization ran againstbuild/html/v0.2.2while the bad file lived elsewhereThis PR normalizes the whole restored build tree, promotes repo-prefixed
wgetoutput into the expected version directory, and removes empty leftover directories.Dependencies: none
Fixes the repeated docs artifact upload failure from run
28218363303.Type of change
Screenshots
N/A
Checklist
black .command to format the code base.Verification
black docs/scripts/merge_published_site.py tests/docs/conftest.py tests/docs/test_merge_published_site.pyblack --check docs/scripts/merge_published_site.py tests/docs/conftest.py tests/docs/test_merge_published_site.pypytest tests/docs -q --confcutdir=tests/docs