Skip to content

Add CODEOWNERS entry for temporalio/contrib #1467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
brianstrauch wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −0
Open

Add CODEOWNERS entry for temporalio/contrib #1467

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,4 @@
# @temporalio/sdk will be requested for review when
# someone opens a pull request.
* @temporalio/sdk
/temporalio/contrib/ @temporalio/ai-sdk
Copy link
Copy Markdown
Contributor

@tconley1428 tconley1428 Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this change the owner, or add additional owners? I don't have a problem with ai-sdk being notified, but it isn't the only owner of all the code there.

Copy link
Copy Markdown
Contributor Author

@brianstrauch brianstrauch Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question. From https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners:

If you want to match two or more code owners with the same pattern, all the code owners must be on the same line. If the code owners are not on the same line, the pattern matches only the last mentioned code owner.

Copy link
Copy Markdown
Contributor

@tconley1428 tconley1428 Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then I don't think we want to do this.

Copy link
Copy Markdown
Contributor

@mjameswh mjameswh Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC, the correct way to do this is (space alignment is totally optional):

*                     @temporalio/sdk
/temporalio/contrib/  @temporalio/ai-sdk @temporalio/sdk

Copy link
Copy Markdown
Contributor

@mjameswh mjameswh Apr 23, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we discussed, we'll want ownership to be:

  1. defined on a per-contrib-subdirectory basis
  2. to include @temporalio/sdk as coowners, to ensure we can handle repo-wide/structural concerns.

So that would give something like this:

*                             @temporalio/sdk
/temporalio/contrib/plugin1   @temporalio/ai-sdk @temporalio/sdk
/temporalio/contrib/plugin2   @temporalio/ai-sdk @temporalio/sdk
/temporalio/contrib/plugin3   @temporalio/ai-sdk @temporalio/sdk

@tconley1428 might have other requirements to add.

Loading