Skip to content

Add CODEOWNERS entry for temporalio/contrib#1467

Open
brianstrauch wants to merge 1 commit intomainfrom
brianstrauch-patch-1
Open

Add CODEOWNERS entry for temporalio/contrib#1467
brianstrauch wants to merge 1 commit intomainfrom
brianstrauch-patch-1

Conversation

@brianstrauch
Copy link
Copy Markdown
Contributor

Allow GitHub notifications to work for the AI SDK team

@brianstrauch brianstrauch requested a review from a team as a code owner April 21, 2026 18:40
Comment thread .github/CODEOWNERS
# @temporalio/sdk will be requested for review when
# someone opens a pull request.
* @temporalio/sdk
/temporalio/contrib/ @temporalio/ai-sdk
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this change the owner, or add additional owners? I don't have a problem with ai-sdk being notified, but it isn't the only owner of all the code there.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question. From https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners:

If you want to match two or more code owners with the same pattern, all the code owners must be on the same line. If the code owners are not on the same line, the pattern matches only the last mentioned code owner.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then I don't think we want to do this.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC, the correct way to do this is (space alignment is totally optional):

*                     @temporalio/sdk
/temporalio/contrib/  @temporalio/ai-sdk @temporalio/sdk

Copy link
Copy Markdown
Contributor

@mjameswh mjameswh Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we discussed, we'll want ownership to be:

  1. defined on a per-contrib-subdirectory basis
  2. to include @temporalio/sdk as coowners, to ensure we can handle repo-wide/structural concerns.

So that would give something like this:

*                             @temporalio/sdk
/temporalio/contrib/plugin1   @temporalio/ai-sdk @temporalio/sdk
/temporalio/contrib/plugin2   @temporalio/ai-sdk @temporalio/sdk
/temporalio/contrib/plugin3   @temporalio/ai-sdk @temporalio/sdk

@tconley1428 might have other requirements to add.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants