[Simulation.Core] WorkerThread: fix memory leak/resource retention#6125
Open
fredroy wants to merge 2 commits into
Open
[Simulation.Core] WorkerThread: fix memory leak/resource retention#6125fredroy wants to merge 2 commits into
fredroy wants to merge 2 commits into
Conversation
fredroy
added
pr: fix
fredroy
force-pushed
the
update_scheduler_dtor_leak
branch
2 times, most recently
from
ef20bb1 to
69d8a29
Compare
bakpaul
added
pr: status wip
fredroy
force-pushed
the
update_scheduler_dtor_leak
branch
from
69d8a29 to
507ffe5
Compare
fredroy
added
pr: status to review
- task->~Task() is now called before operator delete. Because ~Task() is virtual (Task.h:56), this dispatches to the actual derived destructor ~CallableTask, ~SharedPtrHoldingTask, etc. - Captured sizeof(*task) into a local taskSize before calling the destructor, then passed it to operator delete. Reading sizeof(*task) after destruction would technically be reading a destroyed object's vtable, which is UB. With the local capture we sidestep that. (sizeof is a compile-time expression on the static type of *task, so the value is the same but using a local makes the intent explicit and avoids reasoning-trap.)
fredroy
force-pushed
the
update_scheduler_dtor_leak
branch
from
507ffe5 to
e037880
Compare
Contributor
Author
|
[ci-build][with-all-tests] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In WorkerThread, the task destructor was commented. (???)
As of now, the task is only deallocated in memory but the dtor is not called thus its resources are not freed -> memory leak
For now, I am just adding a test illustrating/proving the bug and then will push the fix laterDone
[with-all-tests]
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if