Allow overriding scale_factor in visium hd#394
Merged
LucaMarconato merged 3 commits intomainfrom Apr 30, 2026
Merged
Conversation
Extract scale_factors from image_models_kwargs once via .get() into a local variable and build a filtered copy without the key, so the caller's mapping is never mutated. Reverts the signature back to Mapping[str, Any]. Adds docstring explaining the scale_factors special-case behaviour. Also fixes a missing colon on _infer_dataset_id introduced on the branch. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Member
Author
|
@Tobiaspk thanks for opening the original PR. I made some changes since I wanted to avoid the Also, I documented the usage of |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #394 +/- ##
==========================================
+ Coverage 61.65% 61.85% +0.19%
==========================================
Files 27 26 -1
Lines 3161 3138 -23
==========================================
- Hits 1949 1941 -8
+ Misses 1212 1197 -15
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuing working from #383, original PR from @Tobiaspk.