Skip to content

Bugfix: Allow overriding scale_factor in visium hd#383

Closed
Tobiaspk wants to merge 2 commits intoscverse:mainfrom
dpeerlab:main
Closed

Bugfix: Allow overriding scale_factor in visium hd#383
Tobiaspk wants to merge 2 commits intoscverse:mainfrom
dpeerlab:main

Conversation

@Tobiaspk
Copy link
Copy Markdown
Contributor

@Tobiaspk Tobiaspk commented Mar 5, 2026

Closes #382

Minimal, non-break change to allow users to override scale_factors in visium HD reader. Crashes currently.

@Tobiaspk
Copy link
Copy Markdown
Contributor Author

Tobiaspk commented Mar 5, 2026

Changed typing Mapping to MutableMapping, which supports the pop method. this issue was highlighted by mypy pre-commit.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.98%. Comparing base (433014e) to head (2696766).
⚠️ Report is 30 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #383      +/-   ##
==========================================
+ Coverage   61.65%   63.98%   +2.32%     
==========================================
  Files          27       27              
  Lines        3161     3626     +465     
==========================================
+ Hits         1949     2320     +371     
- Misses       1212     1306      +94     
Files with missing lines Coverage Δ
src/spatialdata_io/readers/visium_hd.py 77.13% <100.00%> (+1.96%) ⬆️

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@LucaMarconato
Copy link
Copy Markdown
Member

Thanks for opening this @Tobiaspk, I'll continue working on this in #394

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Visium HD reader has hardcoded scale factors for full-res images

3 participants