Skip to content

Shader Minifier Mesa Bugfix #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yasirtug wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Shader Minifier Mesa Bugfix #108

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions renderer/src/shaders/minify.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -481,6 +481,10 @@ def emit_tokens_to_rewritten_glsl(self, out, *, preserve_exported_switches, call
out.write('\n')
elif needs_whitespace and lasttoken_needs_whitespace:
out.write(' ')
elif tok.type == "ID" and lasttoken.type == "OP" and lasttoken.value == ")":
# Mesa can reject minified GLSL macro calls when the next
# identifier is directly adjacent, e.g. OUT(float2)foo.
out.write(' ')

# is_newline will be false once we output the token (unless this value otherwise gets
# updated).
Expand Down