Skip to content

fix(emails): make filename and content_disposition nullable in EmailAttachment types #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
drish merged 1 commit into from
May 12, 2026
+8 −8
Merged

fix(emails): make filename and content_disposition nullable in EmailAttachment types #205

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions resend/emails/_received_email.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@ class EmailAttachment(TypedDict):

Attributes:
id (str): The attachment ID.
filename (str): The filename of the attachment.
filename (Optional[str]): The filename of the attachment.
content_type (str): The content type of the attachment.
content_disposition (str): The content disposition of the attachment.
content_disposition (Optional[str]): The content disposition of the attachment.
content_id (NotRequired[str]): The content ID for inline attachments.
size (NotRequired[int]): The size of the attachment in bytes.
"""
Expand All @@ -22,15 +22,15 @@ class EmailAttachment(TypedDict):
"""
The attachment ID.
"""
filename: str
filename: Optional[str]
"""
The filename of the attachment.
"""
content_type: str
"""
The content type of the attachment.
"""
content_disposition: str
content_disposition: Optional[str]
"""
The content disposition of the attachment.
"""
Expand All @@ -51,9 +51,9 @@ class EmailAttachmentDetails(TypedDict):
Attributes:
object (str): The object type.
id (str): The attachment ID.
filename (str): The filename of the attachment.
filename (Optional[str]): The filename of the attachment.
content_type (str): The content type of the attachment.
content_disposition (str): The content disposition of the attachment.
content_disposition (Optional[str]): The content disposition of the attachment.
content_id (NotRequired[str]): The content ID for inline attachments.
download_url (str): The URL to download the attachment.
expires_at (str): When the download URL expires.
Expand All @@ -67,15 +67,15 @@ class EmailAttachmentDetails(TypedDict):
"""
The attachment ID.
"""
filename: str
filename: Optional[str]
"""
The filename of the attachment.
"""
content_type: str
"""
The content type of the attachment.
"""
content_disposition: str
content_disposition: Optional[str]
"""
The content disposition of the attachment.
"""
Expand Down
Loading