fix(emails): make filename and content_disposition nullable in EmailAttachment types#205
Merged
drish merged 1 commit intoMay 12, 2026
Conversation
…ttachment types Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
gabrielmfern
approved these changes
May 12, 2026
Member
|
good to ask @drish for a review here too |
Contributor
There was a problem hiding this comment.
cubic analysis
No issues found across 1 file
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Linked issue analysis
Linked issue: DEV-609: received email attachment types in python
| Status | Acceptance criteria | Notes |
|---|---|---|
| ✅ | Make filename nullable (Optional[str]) in EmailAttachment and EmailAttachmentDetails | Diff changes the filename field type to Optional[str] in both EmailAttachment and EmailAttachmentDetails TypedDicts. |
| ✅ | Make content_disposition nullable (Optional[str]) in EmailAttachment and EmailAttachmentDetails | Diff changes the content_disposition field type to Optional[str] in both EmailAttachment and EmailAttachmentDetails TypedDicts. |
Auto-approved: This change only updates two type annotations from str to Optional[str] in EmailAttachment and EmailAttachmentDetails TypedDicts, aligning with the API spec where filename and content_disposition can be null, with no impact on runtime logic or broader system behavior.
drish
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
open api spec updated here: resend/resend-openapi#64
Summary by cubic
Make
filenameandcontent_dispositionnullable in received email attachment types to match API responses and avoid type errors. Applies toEmailAttachmentandEmailAttachmentDetailsinresend/emails/_received_email.pyand addresses DEV-609.filenameandcontent_dispositionfromstrtoOptional[str]inEmailAttachmentandEmailAttachmentDetails.Written for commit e4e9b27. Summary will update on new commits.