Skip to content

Fix rolling CI and add Lyrical builds #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skyegalaxy merged 2 commits into from
Jul 13, 2026
Merged

Fix rolling CI and add Lyrical builds #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b45d87f
add lyrical builds and build rolling against resolute
Jul 13, 2026
d97161d
fix boost linking for newer versions
Jul 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,10 @@ jobs:
ubuntu: noble
- ros: kilted
ubuntu: noble
- ros: lyrical
ubuntu: resolute
- ros: rolling
ubuntu: noble
ubuntu: resolute
name: ROS 2 ${{ matrix.ros }}
container:
image: ghcr.io/ros-tooling/setup-ros-docker/setup-ros-docker-ubuntu-${{ matrix.ubuntu }}:latest
Expand Down
4 changes: 2 additions & 2 deletions axiomatic_adapter/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ endif()
# Find dependencies
find_package(ament_cmake REQUIRED)
find_package(ament_cmake_ros REQUIRED)
find_package(Boost REQUIRED COMPONENTS system)

@davidt315 davidt315 Jul 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this because it's in a different part of boost in future revisions? i remember doing this as a best practice to only include from boost what is needed, but it's a nit idc that much

@skyegalaxy skyegalaxy Jul 13, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, supposedly boost::asio and boost::system::error_code became header-only since Boost 1.69, so there's no compiled system component to find on newer distros. Humble and jazzy resolved it via the FindBoost module, but Rolling/lyrical builds now use an upstream BoostConfig.cmake, which requires a boost_system-config.cmake component package which is nonexistent for the header-only libraries. Just targeting the one header ended up working across all ROS distros

find_package(Boost REQUIRED)
find_package(CLI11 REQUIRED)
find_package(socketcan_adapter REQUIRED)

Expand All @@ -56,7 +56,7 @@ set_target_properties(axiomatic_adapter PROPERTIES LINK_FLAGS "-Wl,--no-undefine
target_link_libraries(axiomatic_adapter
PUBLIC socketcan_adapter::socketcan_adapter
PRIVATE
Boost::system
Boost::boost
)

install(DIRECTORY include/ DESTINATION include)
Expand Down
Loading