Fix rolling CI and add Lyrical builds#16
Merged
Conversation
added 2 commits
July 13, 2026 14:43
Signed-off-by: Skyler Medeiros <skye@polymathrobotics.com>
Signed-off-by: Skyler Medeiros <skye@polymathrobotics.com>
skyegalaxy
marked this pull request as ready for review
July 13, 2026 21:47
davidt315
approved these changes
Jul 13, 2026
| # Find dependencies | ||
| find_package(ament_cmake REQUIRED) | ||
| find_package(ament_cmake_ros REQUIRED) | ||
| find_package(Boost REQUIRED COMPONENTS system) |
Contributor
There was a problem hiding this comment.
is this because it's in a different part of boost in future revisions? i remember doing this as a best practice to only include from boost what is needed, but it's a nit idc that much
Member
Author
There was a problem hiding this comment.
yeah, supposedly boost::asio and boost::system::error_code became header-only since Boost 1.69, so there's no compiled system component to find on newer distros. Humble and jazzy resolved it via the FindBoost module, but Rolling/lyrical builds now use an upstream BoostConfig.cmake, which requires a boost_system-config.cmake component package which is nonexistent for the header-only libraries. Just targeting the one header ended up working across all ROS distros
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.