fix: correct exported-symbol detection for literal and object-literal exports

[carlos-alm]

Summary

• handleExportCapture/handleExportStmt (JS/TS extractor, both query and walk paths) and the native handle_export_declaration only recognized function/class/interface/type-alias declarations as exports — export const/let/var … was never marked exported in either engine, regardless of initializer shape. This left the exported DB column unset for every exported constant.
• Separately, whereFileImpl computed its exported array via cross-file calls edges instead of the exported DB column (unlike exportsFileImpl, which already did this correctly) — so even DB data alone wasn't the full picture for where --file.
• Fixed both: extractor now classifies exported var/const/let declarations the same way handleVariableDeclarator does; whereFileImpl now shares exportsFileImpl's correct logic via a new findExportedNodesByFile helper.

Closes #1728

Test plan

• npm test — full suite green (3378 passed, 0 failed)
• npm run lint — clean
• Native Rust rebuilt, codesigned, and used for end-to-end verification
• Both repro cases confirmed fixed against the real native engine: MAX_WALK_DEPTH (bare-literal init) and command (object-literal-with-methods, all 49 CLI command files) now appear in exported

Filed #1817, #1818, #1819 for out-of-scope findings surfaced during investigation (pre-existing Rust warning, native/WASM ordering-only divergence, a separate "not extracted as a definition at all" gap for member/call-expression initializers).

Stacked on #1816 (base branch fix/issue-1726-fnimpact-query-file-crash) — only the extractor/repository/analysis/test diff is this issue's change.

[greptile-apps]

Greptile Summary

This PR fixes two related bugs in exported-symbol detection: (1) the TS and Rust extractors only recognized function/class/interface/type-alias export statements and silently dropped every export const/let/var …, leaving exported = 0 in the DB; (2) whereFileImpl used a cross-file calls-edge heuristic to determine the exported surface instead of the exported column, so value-only exports (e.g. constants never called from other files) were invisible to codegraph where --file.

• Extractor fix: New collectExportedDeclarations (TS) and collect_exported_var_declarations (Rust) classify each declarator in a lexical_declaration/variable_declaration using the same kind predicate (isConstantValue/is_js_literal) as the matching Definition-building paths, ensuring the (name, kind, file, line) tuple used by the UPDATE SET exported = 1 query matches the already-inserted row.
• Repository refactor: findExportedNodesByFile is extracted into db/repository/nodes.ts as a shared helper that prefers the exported = 1 column and falls back to the cross-file-calls heuristic for pre-column DBs, replacing duplicated inline logic in exports.ts and symbol-lookup.ts.
• Test coverage: Parser unit tests, query-vs-walk parity tests, native-vs-WASM engine parity tests, and an integration test with a zero-call-edge exported constant all added.

Confidence Score: 5/5

Safe to merge — the change is narrowly scoped to export detection and the shared-helper extraction, both paths are covered by parity and integration tests, and the UPDATE predicate alignment was verified against the DB schema.

Both the TS and Rust extractor changes mirror the existing definition-building kind predicates exactly (isConstantValue/is_js_literal, same function-type list), so the (name, kind, file, line) tuple written by the export collector matches the row already inserted for the definition. The shared findExportedNodesByFile helper is a straightforward consolidation of logic that was already correct in exportsFileImpl; the only material change is that whereFileImpl now uses the same correct path. Test coverage spans parser unit tests, query-vs-walk parity, native-vs-WASM engine parity, and an integration fixture with a zero-edge exported constant specifically targeting the regression.

No files require special attention.

Important Files Changed

Filename	Overview
src/extractors/javascript.ts	Adds collectExportedDeclarations shared helper that classifies each declarator in an exported const/let/var declaration by the same kind predicate used in the definition-building path; both handleExportCapture and handleExportStmt now delegate to it, eliminating the drift risk.
crates/codegraph-core/src/extractors/javascript.rs	Adds collect_exported_var_declarations called from handle_export_declaration for lexical_declaration/variable_declaration; uses the same is_js_literal predicate and is_const check as handle_var_decl, and is consistent with the start_line(node) used in definition inserts.
src/db/repository/nodes.ts	Introduces findExportedNodesByFile with a cached column-presence probe and a knownSymbols optimisation parameter for the legacy-DB fallback path; logic is a clean extraction of what was previously duplicated in exports.ts.
src/domain/analysis/exports.ts	Removes all inline hasExportedCol/_hasExportedColCache logic and replaces it with calls to findExportedNodesByFile; exportsFileImpl passes its already-fetched symbols array to avoid a second query in the legacy-DB path.
src/domain/analysis/symbol-lookup.ts	Replaces the findCrossFileCallTargets heuristic in whereFileImpl with findExportedNodesByFile, fixing the bug where value-only exports were omitted from codegraph where --file's exported list.
tests/integration/queries.test.ts	Adds API_VERSION constant node with exported=1 but no incoming edges as a regression fixture for #1728; asserts it appears in where --file's exported list independent of any call graph membership.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["export const X = 42 / export const fn = () => {}"] --> B{Extractor Path}
    B -- "Query (TS)" --> C["handleExportCapture\n→ collectExportedDeclarations"]
    B -- "Walk (TS)" --> D["handleExportStmt\n→ collectExportedDeclarations"]
    B -- "Native (Rust)" --> E["handle_export_declaration\n→ collect_exported_var_declarations"]
    C --> F["ExportInfo {name, kind, line}"]
    D --> F
    E --> F
    F --> G["INSERT OR IGNORE nodes …\nUPDATE SET exported=1\nWHERE name=? AND kind=? AND file=? AND line=?"]

    H["codegraph exports / where --file"] --> I["findExportedNodesByFile(db, file)"]
    I --> J{hasExportedColumn?}
    J -- "Yes (modern DB)" --> K["SELECT * FROM nodes\nWHERE exported=1"]
    J -- "No (legacy DB)" --> L["findCrossFileCallTargets\n(heuristic fallback)"]
    K --> M["Correct exported surface\n(includes value-only exports)"]
    L --> M

Loading

%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
    A["export const X = 42 / export const fn = () => {}"] --> B{Extractor Path}
    B -- "Query (TS)" --> C["handleExportCapture\n→ collectExportedDeclarations"]
    B -- "Walk (TS)" --> D["handleExportStmt\n→ collectExportedDeclarations"]
    B -- "Native (Rust)" --> E["handle_export_declaration\n→ collect_exported_var_declarations"]
    C --> F["ExportInfo {name, kind, line}"]
    D --> F
    E --> F
    F --> G["INSERT OR IGNORE nodes …\nUPDATE SET exported=1\nWHERE name=? AND kind=? AND file=? AND line=?"]

    H["codegraph exports / where --file"] --> I["findExportedNodesByFile(db, file)"]
    I --> J{hasExportedColumn?}
    J -- "Yes (modern DB)" --> K["SELECT * FROM nodes\nWHERE exported=1"]
    J -- "No (legacy DB)" --> L["findCrossFileCallTargets\n(heuristic fallback)"]
    K --> M["Correct exported surface\n(includes value-only exports)"]
    L --> M

Loading

_{Reviews (4): Last reviewed commit: "Merge origin/main into fix/issue-1728-wh..." | Re-trigger Greptile}

[github-actions]

Codegraph Impact Analysis

8 functions changed → 17 callers affected across 8 files

• hasExportedColumn in src/db/repository/nodes.ts:193 (6 transitive callers)
• findExportedNodesByFile in src/db/repository/nodes.ts:226 (7 transitive callers)
• collectReexportedSymbols in src/domain/analysis/exports.ts:98 (3 transitive callers)
• exportsFileImpl in src/domain/analysis/exports.ts:120 (3 transitive callers)
• whereFileImpl in src/domain/analysis/symbol-lookup.ts:169 (3 transitive callers)
• collectExportedDeclarations in src/extractors/javascript.ts:223 (6 transitive callers)
• handleExportCapture in src/extractors/javascript.ts:257 (3 transitive callers)
• handleExportStmt in src/extractors/javascript.ts:1491 (3 transitive callers)

[carlos-alm]

@greptileai