fix: exclude primitive type keywords from ast --kind string matching

[carlos-alm]

Summary

• codegraph ast --kind string matched AST nodes by node.type/node.kind() string alone. Tree-sitter-typescript's grammar reuses the literal string "string" for two different node-types entries: a named node (real string literals) and an anonymous token (the string primitive type keyword in predefined_type). Without checking named-vs-anonymous, name: string type annotations were misclassified as string literals.
• Fixed in both engines: native Rust walker now guards on is_named() for the "string"/"template_string" arm; TS/WASM side adds astRequiresNamedNode(langId) (scoped to javascript/typescript/tsx) threaded through the ast-store visitor and its three production call sites.

Closes #1729

Test plan

• npm test — full suite green (3388 passed, 0 failed)
• npm run lint — clean
• Native addon rebuilt, codesigned, verified directly
• Repro confirmed: visitor-utils.ts string-kind hits dropped 49→14 (line 10 name: string; no longer present, genuine literals like '../types.js' still present); cfg-shared.ts 18→0 false positives
• New tests verified non-tautological (temporarily reverted fix, confirmed the new assertions fail, restored)

Filed #1821 for an out-of-scope finding: PHP has the identical bug (primitive_type > string unnamed token colliding with encapsed_string/string literals via PHP_AST_TYPES).

Stacked on #1820 (base branch fix/issue-1728-where-file-exported-omissions) — only the ast-analysis/extractor/test diff is this issue's change.

[greptile-apps]

Greptile Summary

Fixes a false-positive in codegraph ast --kind string caused by tree-sitter-typescript reusing the string "string" for both a named literal node and an anonymous keyword token inside predefined_type. Without a named-vs-anonymous guard, type annotations like name: string were captured as string literals.

• Rust side: adds if node.is_named() to the "string" | "template_string" match arm in walk_ast_nodes_depth, leaving all other arms unchanged.
• WASM/TS side: introduces astRequiresNamedNode(langId) (returns true for js/ts/tsx) threaded through all three createAstStoreVisitor call sites plus the parity test; resolveAstKind rejects anonymous string/template_string tokens when the flag is set, exactly mirroring the Rust arm scope.
• Tests: adds TS, TSX, and native-engine fixture suites asserting that type-keyword tokens are excluded while genuine literals, template literals, and string-literal types are still captured.

Confidence Score: 5/5

Safe to merge — the fix is narrowly scoped, mirrored identically across both engines, and backed by new fixture tests that confirm both false-positive elimination and true-positive preservation.

Both engines receive the same targeted guard (named-vs-anonymous on exactly string/template_string), all three TS call sites and the parity test are updated, and the new test suite directly reproduces the original bug. No existing functionality is widened or removed.

tests/parsers/ast-nodes.test.ts — the two native-engine false-positive tests assert the same predicate; a suggestion to align them with the line-number checks used in the WASM suite was left inline.

Important Files Changed

Filename	Overview
crates/codegraph-core/src/extractors/javascript.rs	Adds if node.is_named() guard to the `"string"
src/ast-analysis/rules/index.ts	Introduces astRequiresNamedNode(langId) scoped to the JS/TS/TSX grammar family, with clear documentation of why PHP is excluded (separate issue #1821).
src/ast-analysis/visitors/ast-store-visitor.ts	Adds requireNamedNode param to createAstStoreVisitor and guards only string/template_string types in resolveAstKind, precisely mirroring the Rust arm scope.
src/types.ts	Adds isNamed: boolean to TreeSitterNode interface matching the web-tree-sitter property getter; includes a doc-comment explaining the collision scenario.
src/ast-analysis/engine.ts	Threads astRequiresNamedNode(langId) through to createAstStoreVisitor — a one-line change consistent with the other two call sites.
src/domain/wasm-worker-entry.ts	Same threading of astRequiresNamedNode as engine.ts — correctly keeps the WASM worker path aligned.
src/features/ast.ts	Third call site for astRequiresNamedNode, completing full coverage of all createAstStoreVisitor invocations.
tests/engines/ast-parity.test.ts	Updates the parity test to pass astRequiresNamedNode(langId) so cross-engine comparison now uses the same guard on both sides.
tests/parsers/ast-nodes.test.ts	Adds comprehensive TS/TSX WASM and native fixture suites; native engine's first two false-positive tests assert the same predicate on the same result set, making them indistinguishable on failure.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["astRequiresNamedNode(langId)"] --> B{langId in JS_REQUIRES_NAMED_NODE?}
    B -->|javascript / typescript / tsx| C[requireNamedNode = true]
    B -->|other| D[requireNamedNode = false]

    C --> E[createAstStoreVisitor]
    D --> E

    E --> F["resolveAstKind(node, astTypeMap, requireNamedNode)"]
    F --> G{node.type in astTypeMap?}
    G -->|No| H[return null — skip]
    G -->|Yes| I{requireNamedNode AND node type is string or template_string?}
    I -->|Yes| J{node.isNamed?}
    I -->|No| K[return mapped kind]
    J -->|false — anonymous keyword token| H
    J -->|true — real literal node| K

    subgraph Rust [Native Rust — javascript.rs]
    R1["match node.kind()"] --> R2{"string | template_string\nif node.is_named()"}
    R2 -->|named| R3[process literal]
    R2 -->|anonymous keyword| R4[skip arm — no match]
    end

Loading

%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
    A["astRequiresNamedNode(langId)"] --> B{langId in JS_REQUIRES_NAMED_NODE?}
    B -->|javascript / typescript / tsx| C[requireNamedNode = true]
    B -->|other| D[requireNamedNode = false]

    C --> E[createAstStoreVisitor]
    D --> E

    E --> F["resolveAstKind(node, astTypeMap, requireNamedNode)"]
    F --> G{node.type in astTypeMap?}
    G -->|No| H[return null — skip]
    G -->|Yes| I{requireNamedNode AND node type is string or template_string?}
    I -->|Yes| J{node.isNamed?}
    I -->|No| K[return mapped kind]
    J -->|false — anonymous keyword token| H
    J -->|true — real literal node| K

    subgraph Rust [Native Rust — javascript.rs]
    R1["match node.kind()"] --> R2{"string | template_string\nif node.is_named()"}
    R2 -->|named| R3[process literal]
    R2 -->|anonymous keyword| R4[skip arm — no match]
    end

Loading

_{Reviews (4): Last reviewed commit: "Merge origin/main into fix/issue-1729-as..." | Re-trigger Greptile}

[github-actions]

Codegraph Impact Analysis

8 functions changed → 13 callers affected across 4 files

• setupAstVisitor in src/ast-analysis/engine.ts:458 (3 transitive callers)
• astRequiresNamedNode in src/ast-analysis/rules/index.ts:398 (9 transitive callers)
• resolveAstKind in src/ast-analysis/visitors/ast-store-visitor.ts:291 (1 transitive callers)
• createAstStoreVisitor in src/ast-analysis/visitors/ast-store-visitor.ts:301 (9 transitive callers)
• enterNode in src/ast-analysis/visitors/ast-store-visitor.ts:328 (0 transitive callers)
• buildAstVisitor in src/domain/wasm-worker-entry.ts:593 (3 transitive callers)
• walkAst in src/features/ast.ts:227 (3 transitive callers)
• TreeSitterNode.isNamed in src/types.ts:789 (0 transitive callers)

[carlos-alm]

@greptileai