bsd style receive method for ngx.socket.tcp#861
Open
brg-liuwei wants to merge 2 commits intoopenresty:masterfrom
Open
bsd style receive method for ngx.socket.tcp#861brg-liuwei wants to merge 2 commits intoopenresty:masterfrom
brg-liuwei wants to merge 2 commits intoopenresty:masterfrom
Conversation
| "zzz", | ||
| }, | ||
| } | ||
| local i = math.random(2) |
Member
There was a problem hiding this comment.
Let's test the simplest thing that could possibly work. Complicated test cases are hard to debug when they fail. It took me a while to understand what this test case is trying to do. Better make it as straight forward as possible. No tricks please. Thanks!
Closed
spacewander
requested changes
Feb 13, 2018
| @@ -0,0 +1,94 @@ | |||
| # vim:set ft= ts=4 sw=4 et fdm=marker: | |||
|
|
|||
| use Test::Nginx::Socket::Lua 'no_plan'; | |||
Member
There was a problem hiding this comment.
Better to avoid using no_plan in the lua-nginx-module test suite.
What need to do is just copy the run test number from Bad plan error message.
| [error] | ||
| --- error_log | ||
| lua tcp socket read bsd | ||
|
|
Member
There was a problem hiding this comment.
The trailing line here is unnecessary.
|
|
||
| dd("data read: %.*s", (int) bytes, b->pos); | ||
|
|
||
| u->buf_in->buf->last = ngx_cpymem(u->buf_in->buf->last, b->pos, bytes); |
Member
There was a problem hiding this comment.
u->buf_in->buf and b actually point to the same buffer. So there is no need to copy the content. Just increase the pointer position is enough.
agentzh
requested changes
Feb 26, 2018
zhuizhuhaomeng
force-pushed
the
master
branch
from
f924579 to
fef2581
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@agentzh bsd style receive for ngx.socket.tcp in lua-nginx-module, and add a comment in the document. Maybe I need to add more test cases, yes?
@mike07026 bsd style receive for cosocket in http has accomplished. Good day.
I hereby granted the copyright of the changes in this pull request to the authors of this lua-nginx-module project.