Add receiveatmost.#1146
Closed
robertabcd wants to merge 1 commit intoopenresty:masterfrom
Closed
Conversation
receiveatmost is just like receive, but does not wait until the receive buffer is fully filled, or the timeout passes. It receive at least 1 byte and at most N bytes, specified by the argument. This is useful as there's currently no nonblocking reads. Users can process input as soon as data arrives.
Member
|
@robertabcd I think we already have a similar pending PR: We meant to merge it once it passes all of our review. |
Author
|
Oh, didn't notice that. That one certainly looks better. Feel free to drop this one, as I noticed some tests are failing. It would take time for me to fix that too. |
|
This pull request is now in conflict :( |
f924579 to
fef2581
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
receiveatmost is just like receive, but does not wait until the receive
buffer is fully filled, or the timeout passes. It receive at least 1
byte and at most N bytes, specified by the argument.
This is useful as there's currently no nonblocking reads. Users can
process input as soon as data arrives.
Note: I'm not very familiar with nginx development. Inputs are appreciated.