Skip to content

fix: document suppressed client cleanup errors #3436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nightcityblade wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −2
Open

fix: document suppressed client cleanup errors #3436

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/openai/_base_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -837,7 +837,9 @@ def __del__(self) -> None:
try:
self.close()
except Exception:
pass
# Suppress destructor cleanup errors; object finalizers should not raise
# during garbage collection or interpreter shutdown.
return


class SyncAPIClient(BaseClient[httpx.Client, Stream[Any]]):
Expand Down Expand Up @@ -1434,7 +1436,9 @@ def __del__(self) -> None:
# TODO(someday): support non asyncio runtimes here
asyncio.get_running_loop().create_task(self.aclose())
except Exception:
pass
# Suppress destructor cleanup errors; object finalizers should not raise
# during garbage collection or interpreter shutdown.
return


class AsyncAPIClient(BaseClient[httpx.AsyncClient, AsyncStream[Any]]):
Expand Down