fix: document suppressed client cleanup errors#3436
Open
nightcityblade wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes being requested
Replace empty
except Exception: passhandlers in the sync and async HTTP client wrapper destructors with explicit comments andreturnstatements. This keeps destructor cleanup failures suppressed intentionally while making the behavior clear.Fixes #3428
Additional context & links
Tests run:
ruff check src/openai/_base_client.pyruff format --check src/openai/_base_client.pygit diff --checkpytest tests/test_client.py::TestOpenAI::test_parse_retry_after_header tests/test_client.py::TestAsyncOpenAI::test_parse_retry_after_header(32 passed)