Give overdue-chore alerts the same Alarm/Notification/Silent + DND wiring as tasks#89
Merged
Merged
Conversation
…ring as tasks Overdue chore notifications (DailyStaleChoreWorker) used a single fixed channel with no Do Not Disturb bypass and no alarm/silent variants, unlike task reminders and standalone reminders which already resolved one of three channels from the global delivery-mode setting. Consolidates channel definitions and delivery-mode resolution into one table (NotificationHelper.channelDefs) keyed by ReminderKind, so chores, tasks, and reminders share a single lookup instead of parallel per-feature copies that can drift out of sync. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qm7eATQjSFNReRvTtcXEmG
mapgie
marked this pull request as ready for review
July 12, 2026 10:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Auditing the notification categories screen (see attached screenshot in the conversation) showed "Overdue chores" as a single toggle, while task reminders had three (Alarm/Notification/Silent). Digging in confirmed the split: task reminders and standalone reminders (including chore-linked reminders) already resolved one of three channels from the global delivery-mode setting, with the Alarm channel bypassing Do Not Disturb when access is granted. The
DailyStaleChoreWorker's "Overdue chores" summary notification, however, used a single fixed channel (dash_chore_alerts,IMPORTANCE_DEFAULT) with no DND-bypass capability and no alarm/silent variants — it never read the delivery-mode setting at all.dash_chore_alerts_alarm_v1/_notif_v1/_silent_v1), with the alarm channel bypassing DND when access is granted, same as task reminders.DailyStaleChoreWorkernow reads the same globaldeliveryModesetting used by tasks/reminders and resolves its channel from it.NotificationHelper.channelDefs, keyed by a newReminderKindenum) instead of two near-duplicate implementations, so there's a single place that can drift out of sync when the delivery modes or channel set change.AlarmReceiverandBootWorkernow call the sameNotificationHelper.channelId(kind, mode)function thatDailyStaleChoreWorkeruses.Chores, tasks, and standalone reminders now all go through the same delivery-mode resolution and channel-creation logic.
Test plan