Document shared delivery-mode channel table pattern in LESSONS.md#90
Document shared delivery-mode channel table pattern in LESSONS.md#90mapgie wants to merge 1 commit into
Conversation
Captures the consolidation from PR #89: instead of copy-pasting a per-feature delivery-mode -> channel function each time a new notification source needs Alarm/Notification/Silent + DND-bypass support, model it as one ReminderKind x ChannelStyle table that every caller resolves through. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qm7eATQjSFNReRvTtcXEmG
|
Heads-up on a Suggested resolution: let #92 merge first, then rebase this PR and renumber this lesson to (Underlying point: sequential hand-numbered lessons keep colliding across concurrent PRs, the same problem the changelog fragment system was built to avoid. Worth considering dropping the numbers entirely, but that's a separate change.) Generated by Claude Code |
Summary
LESSONS.md, capturing the notification-channel consolidation from Give overdue-chore alerts the same Alarm/Notification/Silent + DND wiring as tasks #89: when a new feature (overdue-chore alerts) needed the same Alarm/Notification/Silent + DND-bypass treatment as an existing one (task/reminder alerts), the transferable lesson is to model it as oneReminderKindxChannelStyletable that every caller resolves through, rather than copy-pasting a second parallelchannelForDeliveryMode()-style function and a second hand-written channel-creation block that can drift out of sync with the first.No app code changes;
LESSONS.mdisn't one of the file types that requires a changelog fragment per this repo's conventions.Generated by Claude Code