Skip to content

Document shared delivery-mode channel table pattern in LESSONS.md#90

Draft
mapgie wants to merge 1 commit into
mainfrom
claude/choredash-reminder-notifications-14lmpt
Draft

Document shared delivery-mode channel table pattern in LESSONS.md#90
mapgie wants to merge 1 commit into
mainfrom
claude/choredash-reminder-notifications-14lmpt

Conversation

@mapgie

@mapgie mapgie commented Jul 12, 2026

Copy link
Copy Markdown
Owner

Summary

No app code changes; LESSONS.md isn't one of the file types that requires a changelog fragment per this repo's conventions.


Generated by Claude Code

Captures the consolidation from PR #89: instead of copy-pasting a
per-feature delivery-mode -> channel function each time a new notification
source needs Alarm/Notification/Silent + DND-bypass support, model it as
one ReminderKind x ChannelStyle table that every caller resolves through.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Qm7eATQjSFNReRvTtcXEmG

mapgie commented Jul 12, 2026

Copy link
Copy Markdown
Owner Author

Heads-up on a LESSONS.md numbering collision. PR #92 fixes a pre-existing duplicate ## 27 (two lessons shared it on main) via a cascade renumber, which moves the surfaces lesson to #29 and adds a new #30. This PR currently adds the notification-channel lesson as #29, so the two will conflict at the tail of LESSONS.md.

Suggested resolution: let #92 merge first, then rebase this PR and renumber this lesson to ## 31 (after #92's #30). Target ordering ends up: 27 warn-discard, 28 theme-builder, 29 surfaces, 30 accent-CompositionLocal, 31 delivery-mode channel table.

(Underlying point: sequential hand-numbered lessons keep colliding across concurrent PRs, the same problem the changelog fragment system was built to avoid. Worth considering dropping the numbers entirely, but that's a separate change.)


Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants