Skip to content

Repair TUI thread routing stack#211

Open
andrei-hasna wants to merge 3 commits into
mainfrom
repair/pr0-wave2-tui-routing-stack
Open

Repair TUI thread routing stack#211
andrei-hasna wants to merge 3 commits into
mainfrom
repair/pr0-wave2-tui-routing-stack

Conversation

@andrei-hasna

Copy link
Copy Markdown
Contributor

Summary

Verification

  • cargo fmt --manifest-path codex-rs/Cargo.toml --all
  • cargo test --manifest-path codex-rs/Cargo.toml -p codex-core usage_profile_health
  • cargo test --manifest-path codex-rs/Cargo.toml -p codex-tui --lib scheduled_top_level_thread
  • cargo test --manifest-path codex-rs/Cargo.toml -p codex-tui --lib workflow_manager
  • cargo test --manifest-path codex-rs/Cargo.toml -p codex-tui --lib slash_changelog
  • cargo test --manifest-path codex-rs/Cargo.toml -p codex-tui --lib auto_switch_skips_recently_failed_profile_for_unknown_candidate
  • cargo test --manifest-path codex-rs/Cargo.toml -p codex-tui --lib open_agent_picker
  • cargo test --manifest-path codex-rs/Cargo.toml -p codex-tui --lib enqueue_primary_thread_session
  • cargo test --manifest-path codex-rs/Cargo.toml -p codex-tui --lib finds_loaded_subagent_tree_for_primary_thread
  • cargo test --manifest-path codex-rs/Cargo.toml -p codex-tui --lib changelog_browser
  • cargo test --manifest-path codex-rs/Cargo.toml -p codex-tui --lib thread_started
  • cargo test --manifest-path codex-rs/Cargo.toml -p codex-tui --lib pre_primary_untracked_request_stays_resolvable_on_addressed_thread
  • git diff --check
  • todos redaction scan --file /tmp/pr0-wave2-tui-routing-commit.diff

Notes

  • Full codex-tui --lib was attempted, but the broad suite aborted on an unrelated existing stack overflow in app::tests::loop_actions_ignore_explicit_schedule_ids. The targeted stack tests above passed.
  • Independent adversarial review on account004 found two issues before PR creation: pre-primary untracked ServerRequest orphaning and workflow manager loading-view stacking/spec-id redaction. Both were fixed and covered by targeted regression tests.
  • Local commit/push hooks reported lefthook missing from PATH; explicit diff hygiene and redaction scans passed before push.

@andrei-hasna
andrei-hasna force-pushed the repair/pr0-wave2-tui-routing-stack branch from 9704d47 to 224dfb8 Compare July 15, 2026 07:49
@andrei-hasna

Copy link
Copy Markdown
Contributor Author

Replacement-wave queue state: deferred to the app-server/TUI lane, not a merge candidate in this lane.

Reason: #211 is a large TUI/thread-routing/workflow-manager stack (34 files, +2967/-326) and is currently conflict-marked against current main (DIRTY / CONFLICTING, rebaseable=false by live triage). It is not fully superseded, but it overlaps heavily with app-server/TUI workflow PRs including #143 and #219.

Required next lane action:

No local build/test/schema output is accepted as evidence for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant