Skip to content

Guard agent picker from scheduled thread leaks#199

Closed
andrei-hasna wants to merge 1 commit into
mainfrom
openloops/open-codewith/aa3be075-fa91-4401-a608-8011fd7890d7-dd53292c
Closed

Guard agent picker from scheduled thread leaks#199
andrei-hasna wants to merge 1 commit into
mainfrom
openloops/open-codewith/aa3be075-fa91-4401-a608-8011fd7890d7-dd53292c

Conversation

@andrei-hasna

Copy link
Copy Markdown
Contributor

Summary

  • Prevent non-primary replay channels without verified agent navigation lineage from promoting themselves into /agent.
  • Add a regression with a visible primary thread plus an unrelated top-level scheduled thread.
  • Assert /agent rows and keyboard next/previous exclude the scheduled thread while schedule notifications remain buffered through thread materialization/resume refresh paths.

Validation

  • UV_CACHE_DIR=/tmp/codewith-uv-cache just fmt
  • just test-fast -p codex-tui scheduled_top_level_thread_does_not_leak_into_agent_navigation
  • git diff --check
  • cargo insta pending-snapshots from codex-rs/tui
  • staged secret-pattern scan before commit

Notes

  • just test -p codex-tui was run. The new regression passed, but the package gate failed in 11 unrelated chatwidget snapshot/status/terminal-title tests: 3254 passed, 11 failed, 4 skipped. The generated unrelated .snap.new files were removed and cargo insta pending-snapshots reports no pending snapshots.

Todos task: aa3be075-fa91-4401-a608-8011fd7890d7

@andrei-hasna
andrei-hasna force-pushed the openloops/open-codewith/aa3be075-fa91-4401-a608-8011fd7890d7-dd53292c branch from 8f6af9e to 8ccb37d Compare July 7, 2026 19:57
@andrei-hasna

Copy link
Copy Markdown
Contributor Author

Closing as superseded by #211. Replacement #211 consolidates the current TUI/thread-routing stack and explicitly supersedes this PR. Please continue review on #211.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant