-
Notifications
You must be signed in to change notification settings - Fork 35
Update theming logic for Hosted Content pages #16231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
38be413
add hosted override colours to gallery layout
cemms1 dd36c05
add storybook variation for hosted content lightbox
cemms1 d840740
duplicate colour overrides function in each hosted content layout com…
cemms1 5f81d5d
extract palette overrides function and use in hosted gallery layout
cemms1 b247eba
rework the hosted content overrides by extracting into a helper file …
cemms1 b69dde4
add data-layout attribute to hosted gallery main tag
cemms1 edb1c93
update stories with hosted palette decorator for accent colour overrides
cemms1 5005443
update chromatic modes for hosted page layouts + refactor hosted arti…
cemms1 4dc9e15
fix theming in storybook for hosted content pages
cemms1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
35 changes: 13 additions & 22 deletions
35
dotcom-rendering/src/components/HostedContentOnwards.stories.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,29 +1,20 @@ | ||
| import { hostedPaletteDecorator } from '../../.storybook/decorators/themeDecorator'; | ||
| import preview from '../../.storybook/preview'; | ||
| import { hostedOnwardsTrails } from '../../fixtures/manual/onwardsTrails'; | ||
| import { HostedContentOnwards } from './HostedContentOnwards'; | ||
|
|
||
| export default { | ||
| const meta = preview.meta({ | ||
| component: HostedContentOnwards, | ||
| title: 'Components/HostedContentOnwards', | ||
| }; | ||
| args: { | ||
| trails: hostedOnwardsTrails, | ||
| brandName: 'TrendAI', | ||
| }, | ||
| render: (args) => <HostedContentOnwards {...args} />, | ||
| }); | ||
|
|
||
| export const Default = () => { | ||
| return ( | ||
| <HostedContentOnwards | ||
| trails={hostedOnwardsTrails} | ||
| brandName="TrendAI" | ||
| /> | ||
| ); | ||
| }; | ||
| export const Default = meta.story({}); | ||
|
|
||
| Default.storyName = 'default'; | ||
|
|
||
| export const WithAccentColour = () => { | ||
| return ( | ||
| <HostedContentOnwards | ||
| trails={hostedOnwardsTrails} | ||
| brandName="TrendAI" | ||
| /> | ||
| ); | ||
| }; | ||
|
|
||
| WithAccentColour.storyName = 'with accent colour'; | ||
| export const WithAccentColour = meta.story({ | ||
| decorators: hostedPaletteDecorator('#d90c1f'), | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍 moving the overrides to :root makes total sense — LightboxLayout lives outside
<main>so it never could've picked these up before. Much cleaner to follow now.