Skip to content

Use Hosted accent colour for lightbox divider#16231

Draft
cemms1 wants to merge 7 commits into
mainfrom
cemms1/hosted-lightbox-divider-colour
Draft

Use Hosted accent colour for lightbox divider#16231
cemms1 wants to merge 7 commits into
mainfrom
cemms1/hosted-lightbox-divider-colour

Conversation

@cemms1

@cemms1 cemms1 commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

What does this change?

  • Moves the accent colour overrides function from the article layout to a helper function for easier reuse
  • Extracts the hosted content scroll padding to the palette overrides function
  • Uses the palette overrides in the HostedContentPage level instead of the layout level below - this enables us to use the palette override colours for the lightbox divider colour since Lightbox is used at this level
  • Uses the accent colour of the hosted content campaign for the lightbox divider
  • Ensures the other palette colours using the accent colour come through to the HostedGalleryLayout component
  • Adds a Storybook variation for hosted content with accent colour
  • Adds a new Storybook decorator with hosted palette overrides based on the accent colour of the campaign
    • Uses this within Hosted content stories

Why?

We want the lightbox divider colour to be the same as the accent colour of the hosted content campaign.

This is part of the Hosted Content migration from frontend to DCR

Screenshots

Before After
before after

@github-actions

github-actions Bot commented Jun 22, 2026

Copy link
Copy Markdown

@cemms1 cemms1 added Commercial 💰 maintenance Departmental tracking: maintenance work, not a fix or a feature labels Jun 22, 2026
@cemms1 cemms1 force-pushed the cemms1/hosted-lightbox-divider-colour branch from e449665 to 8f623c6 Compare June 23, 2026 10:57
@github-actions

github-actions Bot commented Jun 23, 2026

Copy link
Copy Markdown

@cemms1 cemms1 force-pushed the cemms1/hosted-lightbox-divider-colour branch 2 times, most recently from 700e501 to 3564e53 Compare June 23, 2026 11:27
@cemms1 cemms1 requested a review from a team June 23, 2026 11:31
@cemms1 cemms1 marked this pull request as ready for review June 23, 2026 11:31
@cemms1 cemms1 added the run_chromatic Runs chromatic when label is applied label Jun 23, 2026
@github-actions github-actions Bot removed the run_chromatic Runs chromatic when label is applied label Jun 23, 2026
@cemms1 cemms1 marked this pull request as draft June 23, 2026 11:46
@cemms1 cemms1 removed the request for review from a team June 23, 2026 11:46
@cemms1 cemms1 force-pushed the cemms1/hosted-lightbox-divider-colour branch from 3564e53 to 030348f Compare June 29, 2026 17:46
@cemms1 cemms1 added the run_chromatic Runs chromatic when label is applied label Jun 29, 2026
@github-actions github-actions Bot removed the run_chromatic Runs chromatic when label is applied label Jun 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Commercial 💰 maintenance Departmental tracking: maintenance work, not a fix or a feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant