Skip to content

Fix DIFC proxy shell integration test to use step-scoped proxy environment #26704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 2 commits into from
Apr 16, 2026
Merged

Fix DIFC proxy shell integration test to use step-scoped proxy environment #26704

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ac330a
Initial plan
Copilot Apr 16, 2026
ab1df6e
fix: use step-level proxy env in DIFC sh integration test
Copilot Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2868,6 +2868,12 @@ jobs:
bash actions/setup/sh/start_difc_proxy.sh

- name: Verify DIFC proxy started
env:
GH_HOST: localhost:18443
GH_REPO: ${{ github.repository }}
GITHUB_API_URL: https://localhost:18443/api/v3
GITHUB_GRAPHQL_URL: https://localhost:18443/api/graphql
NODE_EXTRA_CA_CERTS: /tmp/gh-aw/proxy-logs/proxy-tls/ca.crt
run: |
if [ "${GH_HOST}" != "localhost:18443" ]; then
echo "❌ DIFC proxy did not start (GH_HOST=${GH_HOST:-not set})"
Comment on lines 2870 to 2879
Copy link

Copilot AI Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "Verify DIFC proxy started" step now sets GH_HOST (and related vars) explicitly, so the current check if [ "${GH_HOST}" != "localhost:18443" ] will always pass and no longer validates that the proxy is actually running. Consider replacing this with a real readiness check (e.g., assert the CA file exists and curl the proxy health endpoint on https://localhost:18443/api/v3/health using the proxy CA), and only dump container/log diagnostics if that check fails.

Copilot uses AI. Check for mistakes.
Expand Down Expand Up @@ -2904,13 +2910,24 @@ jobs:
- name: Test gh CLI through proxy
env:
GH_TOKEN: ${{ github.token }}
GH_HOST: localhost:18443
GH_REPO: ${{ github.repository }}
GITHUB_API_URL: https://localhost:18443/api/v3
GITHUB_GRAPHQL_URL: https://localhost:18443/api/graphql
NODE_EXTRA_CA_CERTS: /tmp/gh-aw/proxy-logs/proxy-tls/ca.crt
run: |
echo "Testing gh CLI through DIFC proxy (GH_HOST=${GH_HOST})..."
repo_name=$(gh api /repos/${{ github.repository }} --jq '.full_name')
echo "✅ gh CLI works through DIFC proxy (repo: $repo_name)"

- name: Test actions/github-script with proxy env
uses: actions/github-script@3a2844b7e9c422d3c10d287c895573f7108da1b3 # v9
env:
GH_HOST: localhost:18443
GH_REPO: ${{ github.repository }}
GITHUB_API_URL: https://localhost:18443/api/v3
GITHUB_GRAPHQL_URL: https://localhost:18443/api/graphql
NODE_EXTRA_CA_CERTS: /tmp/gh-aw/proxy-logs/proxy-tls/ca.crt
with:
github-token: ${{ github.token }}
script: |
Expand Down
Loading