Skip to content

Stop forwarding rate-limited checkin activities upstream #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feruzm merged 1 commit into from
Jul 12, 2026
Merged

Stop forwarding rate-limited checkin activities upstream #53

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions dotnet/EcencyApi/Handlers/PrivateApi.Misc.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,13 +107,12 @@ public static async Task Activities(HttpContext ctx)
if (!string.IsNullOrEmpty(rec))
{
var nowMs = DateTimeOffset.UtcNow.ToUnixTimeMilliseconds();
if (double.TryParse(rec, System.Globalization.NumberStyles.Float,
var withinWindow = double.TryParse(rec, System.Globalization.NumberStyles.Float,
System.Globalization.CultureInfo.InvariantCulture, out var recMs)
&& nowMs - recMs < 900000)
&& nowMs - recMs < 900000;

if (withinWindow)
{
// Node sends 201 here WITHOUT returning; the cache write and the
// upstream usr-activity call below still run (pipe then skips the
// second response) — replicated as-is.
await ctx.SendJson(201, new JsonObject());
}
try
Expand All @@ -126,6 +125,15 @@ public static async Task Activities(HttpContext ctx)
Console.Error.WriteLine(e);
Console.Error.WriteLine("Cache set failed.");
}
if (withinWindow)
{
// The Node implementation was missing this return: it acked the
// rate-limited checkin with 201 but still forwarded the duplicate
// event upstream (pipe then skipped the second response, logging
// "headers already sent" on every occurrence). Short-circuit after
// refreshing the sliding window, as the branch always intended.
return;
}
}
else
{
Expand Down
Loading