Stop forwarding rate-limited checkin activities upstream#53
Conversation
The ty=10 rate-limit branch acked repeat visits (same IP within 15 min) with an early 201 but was missing a return — inherited from the Node code — so the duplicate event was still POSTed to the private API on every rate-limited hit, and pipe logged 'headers already sent' each time (the only source of that warning in production). Short-circuit after refreshing the sliding window, as the branch always intended. First-seen and stale-window requests are unchanged.
|
Warning Review limit reached
Next review available in: 22 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR stops duplicate rate-limited checkins from being forwarded upstream.
Confidence Score: 5/5This looks safe to merge.
Important Files Changed
Reviews (1): Last reviewed commit: "fix: stop forwarding rate-limited checki..." | Re-trigger Greptile |
The
ty === 10rate-limit branch in the activities handler acks repeat visits (same IP within 15 minutes) with an early 201, but was missing areturn— a bug inherited from the Node implementation. The duplicate checkin event was therefore still POSTed to the private API on every rate-limited hit, defeating the branch's purpose, andpipe()loggedheaders already senteach time (path-attributed diagnostics from #52 show this is the only source of that warning in production, thousands of occurrences per day).The fix short-circuits after sending the 201 and refreshing the sliding cache window, exactly as the branch always intended. First-seen requests and requests outside the 15-minute window are unchanged and still forward upstream. Deliberate behavior change: upstream stops receiving the duplicate events (which its own per-activity accounting rules should already have been discarding).