Skip to content

sdk%fix(ci): use public re-export for double_sha256, execute docs build step in pull requests to catch similar errors #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kwvg merged 2 commits into from
Jun 23, 2026
+13 −3
Merged

sdk%fix(ci): use public re-export for double_sha256, execute docs build step in pull requests to catch similar errors #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eadea66
sdk%fix(samples): use public re-export for `double_sha256`
kwvg Jun 23, 2026
85a4007
sdk%fix(ci): run `pages` build step on PRs to catch regressions
kwvg Jun 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion .github/workflows/pages.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,18 @@ name: Deploy docs
on:
push:
branches: [develop]
pull_request:
paths:
- pkgs/**
- contrib/samples/**
- contrib/zen/**
- contrib/build_docs.py
- docs/zen/**
- .github/workflows/pages.yml
workflow_dispatch:

concurrency:
group: pages
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
cancel-in-progress: true

permissions:
Expand Down Expand Up @@ -60,6 +68,7 @@ jobs:

deploy:
name: Deploy to GitHub Pages
if: github.event_name == 'push' && github.ref == 'refs/heads/develop'
needs: build
runs-on: ubuntu-24.04-arm

Expand Down
5 changes: 3 additions & 2 deletions contrib/samples/solver/solver.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,9 @@ extern crate alloc;
use bitcoin_consensus_encoding::encode_to_vec;
use bitcoin_units::Amount;
use dash_num::{Arith256, CompactTarget};
use dash_primitives::hash::double_sha256;
use dash_primitives::{BlockHash, BlockHeader, MerkleRoot, OutPoint, Script, Transaction, TxHash, TxIn, TxOut, TxType};
use dash_primitives::{
double_sha256, BlockHash, BlockHeader, MerkleRoot, OutPoint, Script, Transaction, TxHash, TxIn, TxOut, TxType,
};
use hex_conservative::FromHex;
use serde::{Deserialize, Serialize};
use wasm_bindgen::prelude::*;
Expand Down
Loading