Skip to content

sdk%fix(ci): use public re-export for double_sha256, execute docs build step in pull requests to catch similar errors#14

Merged
kwvg merged 2 commits into
dashpay:developfrom
kwvg:fix_wasm
Jun 23, 2026
Merged

sdk%fix(ci): use public re-export for double_sha256, execute docs build step in pull requests to catch similar errors#14
kwvg merged 2 commits into
dashpay:developfrom
kwvg:fix_wasm

Conversation

@kwvg

@kwvg kwvg commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator

Motivation

base-sdk#11 introduced changes that broke the GitHub Pages build process introduced in base-sdk#10 as the build is only triggered after a pull request is merged. Both the immediate fix and the CI scope widening are done in the PR to prevent a repeat occurrance.

Breaking Changes

None expected.

How Has This Been Tested?

https://github.com/kwvg/base-sdk/actions/runs/28050610268

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas (note: N/A)
  • I have added or updated relevant unit/integration/functional tests
  • I have made corresponding changes to the documentation (note: N/A)
  • I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

@kwvg kwvg added this to the 0.1 milestone Jun 23, 2026
@kwvg kwvg self-assigned this Jun 23, 2026
@coderabbitai

coderabbitai Bot commented Jun 23, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 7a265eef-4923-4fe4-b29d-60b4b99437f8

📥 Commits

Reviewing files that changed from the base of the PR and between 3d086d8 and 85a4007.

📒 Files selected for processing (2)
  • .github/workflows/pages.yml
  • contrib/samples/solver/solver.rs

📝 Walkthrough

Walkthrough

The Pages GitHub Actions workflow gains a pull_request trigger with path filters, switches to a dynamic concurrency group, and restricts the deploy job to push events on the develop branch. Separately, the solver sample consolidates the double_sha256 import into the grouped dash_primitives use statement.

Changes

Pages Workflow Trigger and Deploy Guard

Layer / File(s) Summary
PR trigger, path filters, and dynamic concurrency group
.github/workflows/pages.yml
Adds a pull_request event trigger with path filters for docs and contrib/pkgs locations, and replaces the static pages concurrency group with a dynamic expression keyed by workflow name and PR number or git ref.
Deploy job restricted to push on develop
.github/workflows/pages.yml
Adds an if condition to the deploy job so it only runs for push events targeting refs/heads/develop, preventing deployment on pull request workflow runs.

Solver Import Consolidation

Layer / File(s) Summary
Consolidate double_sha256 into grouped import
contrib/samples/solver/solver.rs
Removes the standalone use dash_primitives::hash::double_sha256 import and includes double_sha256 inside the existing grouped use dash_primitives::{...} statement.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes both main changes: fixing double_sha256 import and enabling docs build on pull requests.
Description check ✅ Passed The description clearly explains the motivation (regression from PR #11), the fix (import update), and preventive measure (CI scope widening).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

Note

This pull request has no conflicts! 🎊 🎉 🎊

@kwvg kwvg merged commit 3d47c44 into dashpay:develop Jun 23, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant