Skip to content

Clarify markdown table renderer overrides #800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blove merged 2 commits into from
Jul 9, 2026
Merged

Clarify markdown table renderer overrides #800

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
356e8e7
docs: clarify markdown table renderer overrides
blove Jul 9, 2026
0a3bd10
Merge branch 'main' into codex/chat-markdown-table-docs-followup
blove Jul 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions apps/website/content/docs/chat/guides/markdown.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,6 +195,10 @@ The most common mistake is providing `'code'` as an override key — it does not
| `'table-row'` | Table row (`<tr>`) |
| `'table-cell'` | Table header or data cell (`<th>` / `<td>`) |

<Callout type="info" title="Table row and cell overrides">
The built-in `'table'` renderer emits native `<tr>`, `<th>`, and `<td>` elements directly so streamed rows stay attached to the same browser table. Override the `'table'` key when you need to change the built-in table structure. The `'table-row'` and `'table-cell'` keys remain available for custom renderers or direct row/cell rendering, but the default table renderer does not dispatch its child rows through those registry entries.
</Callout>

## Theming Markdown Components

All built-in markdown view components consume the same `--tplane-chat-*` and `--a2ui-*` CSS custom properties as the rest of the chat UI. No extra tokens are needed — changing the active theme automatically re-styles markdown output. See the [chat theming guide](/docs/chat/guides/theming) for the full token reference.
Expand Down
10 changes: 1 addition & 9 deletions libs/chat/src/lib/markdown/views/markdown-table.component.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@ import { Component, signal } from '@angular/core';
import { views } from '@threadplane/render';
import type { MarkdownTableCellNode, MarkdownTableNode, MarkdownTableRowNode } from '@cacheplane/partial-markdown';
import { MarkdownTableComponent } from './markdown-table.component';
import { MarkdownTableRowComponent } from './markdown-table-row.component';
import { MarkdownTableCellComponent } from './markdown-table-cell.component';
import { MARKDOWN_VIEW_REGISTRY } from '../markdown-view-registry';

function makeTableNode(overrides: Partial<MarkdownTableNode> = {}): MarkdownTableNode {
Expand Down Expand Up @@ -55,13 +53,7 @@ describe('MarkdownTableComponent', () => {
beforeEach(() => {
TestBed.configureTestingModule({
imports: [HostComponent],
providers: [{
provide: MARKDOWN_VIEW_REGISTRY,
useValue: views({
'table-row': MarkdownTableRowComponent,
'table-cell': MarkdownTableCellComponent,
}),
}],
providers: [{ provide: MARKDOWN_VIEW_REGISTRY, useValue: views({}) }],
});
});

Expand Down
Loading