Skip to content

Clarify markdown table renderer overrides#800

Merged
blove merged 2 commits into
mainfrom
codex/chat-markdown-table-docs-followup
Jul 9, 2026
Merged

Clarify markdown table renderer overrides#800
blove merged 2 commits into
mainfrom
codex/chat-markdown-table-docs-followup

Conversation

@blove

@blove blove commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Clarifies that the built-in markdown table renderer emits native table rows and cells directly.
  • Updates the table component spec setup so it does not imply default row/cell rendering is dispatched through registry overrides.

Why

The table renderer intentionally avoids custom element hosts between native table sections, rows, and cells so streamed rows stay attached to the same browser table. The docs now make the override boundary explicit for consumers.

Verification

  • npx nx test chat -- --runInBand markdown-table.component.spec.ts
  • npx nx lint chat --skip-nx-cache
  • git diff --check

Notes

  • npx nx lint website is currently blocked by unrelated generated apps/website/public/demo/main.js lint errors on this checkout.
  • npm run generate-agent-context is not needed for this change; that script renders the public context templates, not markdown guide content.

@vercel

vercel Bot commented Jul 9, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
threadplane Ready Ready Preview, Comment Jul 9, 2026 3:32pm

Request Review

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated approval: this PR received an intelligent (AI) code review. See the review comments on this PR.

@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Claude finished @blove's task in 0s —— View job


I'll analyze this and get back to you.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated approval: this PR received an intelligent (AI) code review. See the review comments on this PR.

@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Claude finished @blove's task in 0s —— View job


I'll analyze this and get back to you.

@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Claude finished @blove's task in 0s —— View job


I'll analyze this and get back to you.

@blove blove merged commit e9acaa9 into main Jul 9, 2026
57 checks passed
@blove blove deleted the codex/chat-markdown-table-docs-followup branch July 9, 2026 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant