Skip to content

Replace conversion of binary->string in arrow-row from arraydata to direct construction #10261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alamb merged 1 commit into from
Jul 2, 2026
Merged

Replace conversion of binary->string in arrow-row from arraydata to direct construction #10261

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions arrow-row/src/variable.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,14 +401,11 @@ pub unsafe fn decode_string<I: OffsetSizeTrait>(
return GenericStringArray::from(decoded);
}

let builder = decoded
.into_data()
.into_builder()
.data_type(GenericStringArray::<I>::DATA_TYPE);
let (offsets, values, nulls) = decoded.into_parts();

// SAFETY:
// Row data must have come from a valid UTF-8 array
GenericStringArray::from(unsafe { builder.build_unchecked() })
unsafe { GenericStringArray::new_unchecked(offsets, values, nulls) }
}

/// Decodes a string view array from `rows` with the provided `options`
Expand Down
Loading