Replace conversion of binary->string in arrow-row from arraydata to direct construction#10261
Open
Jefffrey wants to merge 1 commit into
Open
Replace conversion of binary->string in arrow-row from arraydata to direct construction#10261Jefffrey wants to merge 1 commit into
Jefffrey wants to merge 1 commit into
Conversation
…irect construction
af3bc6c to
08c57a3
Compare
Contributor
Author
|
run benchmark row_format |
|
🤖 Arrow criterion benchmark running (GKE) | trigger CPU Details (lscpu)Comparing replace-array-data-row (08c57a3) to 32bba5a (merge-base) diff File an issue against this benchmark runner |
|
🤖 Arrow criterion benchmark completed (GKE) | trigger Instance: CPU Details (lscpu)Details
Resource Usagebase (merge-base)
branch
File an issue against this benchmark runner |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
ArrayDatawith direct Array construction, when possible #9298Rationale for this change
Missed by #10229 as it used the
into_data()API (I was grepping just forArrayData). Instead of roundtripping through arraydata to convert from a binary to string, just directly useinto_parts()andnew_unchecked()for optimization.What changes are included in this PR?
Remove arraydata roundtrip in favour of deconstructing with
into_parts()and constructing withnew_unchecked()Are these changes tested?
Existing tests
Are there any user-facing changes?
No