Edit Builder-backed Content database fields normally#1758
Conversation
This comment has been minimized.
This comment has been minimized.
|
Here's a visual recap of what changed: Open the full interactive recap |
4531031 to
fe6caa9
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Builder reviewed your changes and found 1 potential issue 🟡
Review Details
This PR adds a new stage-builder-source-bulk-update action, extends Builder review prep to accept explicit changeSetIds, and trims heavy row/body payloads out of read snapshots while improving optimistic property updates in the database UI. The backend action/test coverage is substantial, and the scoped review-prep change is a sound way to keep apply limited to the reviewed rows.
Risk assessment: standard. The change spans shared source-sync business logic plus editor/database UI behavior, so the main failure mode is the UI wiring not actually driving the new guarded review path.
Key findings
- 🟡 MEDIUM: the new bulk Builder staging path does not appear to be wired into the selected-row edit flow, so bulk edits still mutate rows through the existing per-row property update path instead of opening the promised staged review dialog.
Positives: the PR adds strong DB-level tests for stale rows, fixture rows, ambiguous mappings, scoped review prep, and unsupported property types; and omitting heavy Builder body payloads from normal table reads should reduce unnecessary response weight.
🧪 Browser testing: Will run after this review (PR touches UI code)

Summary
Safety / Scope
Verification
node_modules/.bin/vitest run app/hooks/use-content-database.test.ts app/components/editor/database/DatabaseView.test.ts actions/stage-builder-source-bulk-update.db.test.tsnode_modules/.bin/tsc --noEmitPATH=/Users/alicemoore/.local/share/fnm/node-versions/v22.21.1/installation/lib/node_modules/corepack/shims:$PATH fnm exec --using v22.21.1 pnpm guardsgit diff --checkpnpm dev:database, confirmedAGENT_NATIVE_MODE=database, and opened Chrome athttp://localhost:8080/.