Fix Content Builder source tag field fidelity#1941
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
We've been automatically notified and are looking into it. Push a new commit to re-trigger the review, or contact support@builder.io if this keeps happening. Error ID: |
…-source-field-fidelity
…-source-field-fidelity
…-source-field-fidelity
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…-source-field-fidelity
|
Here's a visual recap of what changed: Open the full interactive recap |
…-source-field-fidelity
…-source-field-fidelity
|
Addressed Builder review findings in 8ad8f66: imported Builder select/multi-select values now backfill as Content option ids, Builder model field metadata is preserved across metadata rewrites, and generated source option ids are made unique when distinct labels normalize to the same slug. Focused tests cover the backfill, metadata preservation, and collision cases. |
|
Follow-up for the latest Builder review summary: both remaining items it references are addressed in db80492. |
…-source-field-fidelity
There was a problem hiding this comment.
Builder reviewed your changes — looks good ✅
Review Details
Reviewed the latest incremental update for this standard-risk PR touching both Content source-sync logic and the database/editor UI. The overall approach remains sound: Builder model metadata is now carried through the source lifecycle, imported option/value normalization is aligned with the property model, and the bulk multi-select editor keeps the pending-toggle workflow while restoring explicit clear behavior.
I specifically re-checked the two previously open PR comments. The binding-picker mismatch is fixed: the Document Properties gate now keeps raw list/array fields conservative for binding compatibility, so the UI no longer offers the Builder tag-list fields that the backend would reject. The bulk multi-select regression is also fixed: the editor once again exposes a clear-all action alongside Apply/Cancel. I also re-verified the earlier durability/fidelity concerns from the prior review; the updated code now preserves builderModelFields across metadata rewrites and normalizes imported option-backed values through the new options-aware path.
Net result: the new commits address the previously reported issues and I did not find any additional actionable defects in the updated diff.
🧪 Browser testing: Will run after this review (PR touches UI code)

Summary
Verification
PR #1758 coordination