Skip to content

Fix Content Builder source tag field fidelity#1941

Merged
3mdistal merged 12 commits into
mainfrom
codex/content-builder-source-field-fidelity
Jul 8, 2026
Merged

Fix Content Builder source tag field fidelity#1941
3mdistal merged 12 commits into
mainfrom
codex/content-builder-source-field-fidelity

Conversation

@3mdistal

@3mdistal 3mdistal commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Summary

  • preserve Builder tag/list metadata as Content multi-select properties with source options
  • show type-appropriate icons for add-from-source fields
  • make bulk multi-select editing use searchable pending tag toggles before Apply

Verification

  • pnpm oxfmt app/components/editor/database/DatabaseView.tsx app/components/editor/database/DatabaseView.test.ts
  • pnpm vitest run app/components/editor/database/DatabaseView.test.ts
  • PATH="/Users/alicemoore/.cache/codex-runtimes/codex-primary-runtime/dependencies/node/bin:/Users/alicemoore/.cache/codex-runtimes/codex-primary-runtime/dependencies/bin:$PATH" pnpm typecheck

PR #1758 coordination

@netlify

This comment has been minimized.

@netlify

This comment has been minimized.

@netlify

This comment has been minimized.

@netlify

This comment has been minimized.

@netlify

This comment has been minimized.

@netlify

This comment has been minimized.

@netlify

This comment has been minimized.

@netlify

This comment has been minimized.

@netlify

This comment has been minimized.

@netlify

This comment has been minimized.

@netlify

This comment has been minimized.

@netlify

This comment has been minimized.

@3mdistal
3mdistal requested a review from steve8708 July 7, 2026 19:36
@builder-io-integration

Copy link
Copy Markdown
Contributor

⚠️ Review Agent ran into a problem and couldn't finish reviewing the latest commit.

We've been automatically notified and are looking into it. Push a new commit to re-trigger the review, or contact support@builder.io if this keeps happening.

Error ID: 97696af12a934d23a9eb0367ee66243b

builder-io-integration[bot]

This comment was marked as outdated.

builder-io-integration[bot]

This comment was marked as outdated.

@netlify

This comment has been minimized.

@netlify

This comment has been minimized.

@netlify

This comment has been minimized.

@netlify

This comment has been minimized.

@netlify

This comment has been minimized.

@netlify

This comment has been minimized.

@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Here's a visual recap of what changed:

Visual recap

Open the full interactive recap

builder-io-integration[bot]

This comment was marked as outdated.

@3mdistal

3mdistal commented Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

Addressed Builder review findings in 8ad8f66: imported Builder select/multi-select values now backfill as Content option ids, Builder model field metadata is preserved across metadata rewrites, and generated source option ids are made unique when distinct labels normalize to the same slug. Focused tests cover the backfill, metadata preservation, and collision cases.

builder-io-integration[bot]

This comment was marked as outdated.

builder-io-integration[bot]

This comment was marked as outdated.

@3mdistal

3mdistal commented Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

Follow-up for the latest Builder review summary: both remaining items it references are addressed in db80492. DocumentProperties.tsx now keeps raw list/array source fields conservative for binding compatibility while preserving explicit tags/multi_select support, and DatabaseView.tsx restores a Clear value action for bulk multi-select editing. Focused tests cover both regressions: DocumentProperties.test.ts for source-field compatibility and DatabaseView.test.ts for the set-empty clear operation.

@builder-io-integration builder-io-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builder reviewed your changes — looks good ✅

Review Details

Reviewed the latest incremental update for this standard-risk PR touching both Content source-sync logic and the database/editor UI. The overall approach remains sound: Builder model metadata is now carried through the source lifecycle, imported option/value normalization is aligned with the property model, and the bulk multi-select editor keeps the pending-toggle workflow while restoring explicit clear behavior.

I specifically re-checked the two previously open PR comments. The binding-picker mismatch is fixed: the Document Properties gate now keeps raw list/array fields conservative for binding compatibility, so the UI no longer offers the Builder tag-list fields that the backend would reject. The bulk multi-select regression is also fixed: the editor once again exposes a clear-all action alongside Apply/Cancel. I also re-verified the earlier durability/fidelity concerns from the prior review; the updated code now preserves builderModelFields across metadata rewrites and normalizes imported option-backed values through the new options-aware path.

Net result: the new commits address the previously reported issues and I did not find any additional actionable defects in the updated diff.

🧪 Browser testing: Will run after this review (PR touches UI code)

@3mdistal
3mdistal merged commit 0af6297 into main Jul 8, 2026
93 checks passed
@3mdistal
3mdistal deleted the codex/content-builder-source-field-fidelity branch July 8, 2026 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants