Skip to content

Revert PR 528#550

Open
luke- wants to merge 5 commits into
yiisoft:2.3.xfrom
luke-:revert-528
Open

Revert PR 528#550
luke- wants to merge 5 commits into
yiisoft:2.3.xfrom
luke-:revert-528

Conversation

@luke-

@luke- luke- commented Feb 17, 2026

Copy link
Copy Markdown
Contributor
Q A
Is bugfix? ✔️
Fixed issues PR #528

Reverts PR #528

samdark and others added 5 commits January 8, 2026 10:52
… 3.0 version (yiisoft#545)

Co-authored-by: Maksim Spirkov <63721828+mspirkov@users.noreply.github.com>
Co-authored-by: Maksim Spirkov <63721828+mspirkov@users.noreply.github.com>
Co-authored-by: Maksim Spirkov <63721828+mspirkov@users.noreply.github.com>
@codecov

codecov Bot commented Feb 17, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 45.65972% with 313 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (2.3.x@e0f935e). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/cli/VerboseBehavior.php 0.00% 42 Missing ⚠️
src/drivers/amqp_interop/Queue.php 40.42% 28 Missing ⚠️
src/drivers/stomp/Queue.php 41.17% 20 Missing ⚠️
src/LogBehavior.php 0.00% 19 Missing ⚠️
src/drivers/sqs/Queue.php 44.11% 19 Missing ⚠️
src/cli/Command.php 0.00% 16 Missing ⚠️
src/drivers/file/InfoAction.php 0.00% 16 Missing ⚠️
src/drivers/beanstalk/Queue.php 72.22% 15 Missing ⚠️
src/drivers/db/InfoAction.php 0.00% 15 Missing ⚠️
src/drivers/file/Queue.php 61.29% 12 Missing ⚠️
... and 26 more
Additional details and impacted files
@@           Coverage Diff            @@
##             2.3.x     #550   +/-   ##
========================================
  Coverage         ?   46.47%           
  Complexity       ?      501           
========================================
  Files            ?       44           
  Lines            ?     1575           
  Branches         ?        0           
========================================
  Hits             ?      732           
  Misses           ?      843           
  Partials         ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rob006

rob006 commented Feb 17, 2026

Copy link
Copy Markdown

This should target 2.x line. Master is going to be released as 3.0.0

@luke-

luke- commented Feb 17, 2026

Copy link
Copy Markdown
Contributor Author

@rob006 Thanks, is there a branch for the 2.x line?

@s1lver

s1lver commented Feb 19, 2026

Copy link
Copy Markdown
Member

I think we could rollback already in version 3.0. Or make a hotfix from 2.3.8

@luke-

luke- commented Feb 19, 2026

Copy link
Copy Markdown
Contributor Author

Both options would be fine for me.

@rob006

rob006 commented Feb 19, 2026

Copy link
Copy Markdown

This should be fixed in patch release - probably a lot of people will stuck on 2.x line and we shouldn't leave it with this bug.

@s1lver

s1lver commented Feb 19, 2026

Copy link
Copy Markdown
Member

This should be fixed in patch release - probably a lot of people will stuck on 2.x line and we shouldn't leave it with this bug.

2.3.8.1 or 2.3.9 ?

@rob006

rob006 commented Feb 19, 2026

Copy link
Copy Markdown

IMO it should be 2.3.9, but AFAIK both will work.

@s1lver s1lver changed the base branch from master to 2.3.x February 20, 2026 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants