Open
Conversation
curvature() divided by (cellsize * cellsize) in every backend kernel
without a zero guard, so a raster with attrs={'res': (0, 0)} returned
inf for every interior pixel instead of raising. Validate cellsize_x
and cellsize_y in the public API before backend dispatch and raise
ValueError when either is zero or non-finite. All four backends
(numpy, cupy, dask+numpy, dask+cupy) inherit the check.
Inner numba/cupy kernels are unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1270.
curvature()divided bycellsize * cellsizein every backend kernel with no zero guard. A raster whoseresattribute was(0, 0)(or had one zero component) producedinffor every interior pixel instead of a clean error.This validates
cellsize_xandcellsize_yfromget_dataarray_resolution(agg)in the publiccurvature()API before backend dispatch and raisesValueErrorwhen either component is zero or non-finite. Inner numba/cupy kernels are unchanged. All four backends (numpy, cupy, dask+numpy, dask+cupy) inherit the check.Cat 3 (NaN/Inf as logic error) MEDIUM-severity finding from the recent security sweep.
Changes
xrspatial/curvature.py: validate cellsize incurvature()before dispatch, raiseValueErrorwhen either component is zero or non-finite.xrspatial/tests/test_curvature.py: parametrized test coveringres=(0, 0),(0, 1),(1, 0),(inf, 1),(1, nan)..claude/sweep-security-state.json: record the curvature inspection.Test plan
pytest xrspatial/tests/test_curvature.py -x(80 passed, 5 new)ValueErroris raised instead of returning inf