Skip to content

Record curvature security sweep results#1265

Merged
brendancol merged 2 commits intomainfrom
record-curvature-security-sweep
Apr 25, 2026
Merged

Record curvature security sweep results#1265
brendancol merged 2 commits intomainfrom
record-curvature-security-sweep

Conversation

@brendancol
Copy link
Copy Markdown
Contributor

Summary

  • First-time audit of xrspatial/curvature.py on 2026-04-25; clean across all six categories.
  • GPU kernel _run_gpu (curvature.py:79-86) has a full bounds guard via the i + di <= out.shape[0] - 1 and j + dj <= out.shape[1] - 1 stencil check.
  • All four backends cast input to float32, and curvature() calls _validate_raster at line 253. Tests cover int32/int64/uint32/uint64/float32/float64.

No source code is changed; only .claude/sweep-security-state.json is updated.

Test plan

  • python -c "import json; json.load(open('.claude/sweep-security-state.json'))" -- JSON is valid.

Audit found no security issues in xrspatial/curvature.py.
@github-actions github-actions Bot added the performance PR touches performance-sensitive code label Apr 25, 2026
@brendancol
Copy link
Copy Markdown
Contributor Author

@copilot resolve the merge conflicts in this pull request

Co-authored-by: brendancol <433221+brendancol@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 25, 2026

@copilot resolve the merge conflicts in this pull request

Resolved in commit 1864373. The conflict was in .claude/sweep-security-state.json — both this branch (adding curvature) and main (adding cost_distance) inserted a new entry at the same location. The resolved file now includes all three new entries: dasymetric, cost_distance, and curvature.

@brendancol brendancol merged commit e1e1ebd into main Apr 25, 2026
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

performance PR touches performance-sensitive code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants