[hal] Resource classes: Use expected, refactor errors#8768
Open
PeterJohnson wants to merge 2 commits intowpilibsuite:2027from
Open
[hal] Resource classes: Use expected, refactor errors#8768PeterJohnson wants to merge 2 commits intowpilibsuite:2027from
PeterJohnson wants to merge 2 commits intowpilibsuite:2027from
Conversation
Instead of taking status by pointer, take by value and return new status instead. Rename from SetLast to Make to make this new usage obvious. Also move from per-target HALInternal.hpp to common ErrorHandling.hpp.
github-actions
bot
added
component: hal
PeterJohnson
force-pushed
the
hal-handle-resource-upgrade
branch
from
6e2f1e0 to
9793f7a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also revamp SetLastError et al; Instead of taking status by pointer, take by value and return new status instead. Rename from SetLast to Make to make this new usage obvious.
Also move declarations for the error functions from duplicated in the per-target HALInternal.hpp to a common ErrorHandling.hpp.