Skip to content

Update wp-cli framework#1086

Closed
schlessera wants to merge 2 commits into
mainfrom
update-framework
Closed

Update wp-cli framework#1086
schlessera wants to merge 2 commits into
mainfrom
update-framework

Conversation

@schlessera

@schlessera schlessera commented Jul 21, 2026

Copy link
Copy Markdown
Member

This is an automated pull-request

Updates the wp-cli/wp-cli framework to the latest changeset.

@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown

Review Change Stack

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • composer.lock is excluded by !**/*.lock

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 57184364-5246-4133-bd84-75fdf8ae206b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

The framework update workflow now uses GITHUB_TOKEN, removes issues: read permission, and switches existing pull request detection from the REST API to gh pr list.

Changes

Framework update workflow

Layer / File(s) Summary
Workflow authentication and PR discovery
.github/workflows/update-framework.yml
The workflow uses GITHUB_TOKEN for checkout and GitHub CLI operations, removes issues: read, and retrieves existing pull request numbers with gh pr list.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers: swissspidy

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly reflects the main change: updating the wp-cli framework.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch update-framework

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the enhancement New feature or request label Jul 21, 2026
@codecov

codecov Bot commented Jul 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/update-framework.yml:
- Around line 29-32: Update the actions/checkout step in the update-framework
workflow to set persist-credentials to false, preventing GITHUB_TOKEN from being
stored in local git configuration. Preserve authentication for the later push by
configuring explicit credentials only in the git push step.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: eb640dac-5ff8-42ac-8aea-3ac6270cb4c0

📥 Commits

Reviewing files that changed from the base of the PR and between 727e898 and dfc54dd.

⛔ Files ignored due to path filters (1)
  • composer.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • .github/workflows/update-framework.yml

Comment on lines 29 to +32
- name: Check out source code
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
token: ${{ secrets.ACTIONS_BOT }}
token: ${{ secrets.GITHUB_TOKEN }}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔒 Security & Privacy | 🟠 Major | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

printf '--- file list ---\n'
git ls-files .github/workflows/update-framework.yml

printf '\n--- line count ---\n'
wc -l .github/workflows/update-framework.yml

printf '\n--- relevant excerpt ---\n'
sed -n '1,220p' .github/workflows/update-framework.yml

Repository: wp-cli/wp-cli-bundle

Length of output: 249


🏁 Script executed:

#!/bin/bash
set -euo pipefail

printf '--- search for checkout usage and credential handling in workflow ---\n'
rg -n "actions/checkout|persist-credentials|GITHUB_TOKEN|GH_TOKEN|git push|composer" .github/workflows/update-framework.yml

Repository: wp-cli/wp-cli-bundle

Length of output: 249


🏁 Script executed:

#!/bin/bash
set -euo pipefail

sed -n '1,220p' .github/workflows/update-framework.yml

Repository: wp-cli/wp-cli-bundle

Length of output: 3450


Disable persisted checkout credentials. actions/checkout stores the GITHUB_TOKEN in local git config by default. This job runs Composer afterward, so a package script or plugin could read the write-capable token before the push step. Set persist-credentials: false and add explicit auth only for git push.

🧰 Tools
🪛 zizmor (1.26.1)

[warning] 29-32: credential persistence through GitHub Actions artifacts (artipacked): does not set persist-credentials: false

(artipacked)

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/update-framework.yml around lines 29 - 32, Update the
actions/checkout step in the update-framework workflow to set
persist-credentials to false, preventing GITHUB_TOKEN from being stored in local
git configuration. Preserve authentication for the later push by configuring
explicit credentials only in the git push step.

Sources: MCP tools, Linters/SAST tools

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request scope:framework

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants