Skip to content

Fix update-framework workflow: Add --json arg#1084

Merged
swissspidy merged 3 commits into
mainfrom
fix/update-framework-workflow
Jul 21, 2026
Merged

Fix update-framework workflow: Add --json arg#1084
swissspidy merged 3 commits into
mainfrom
fix/update-framework-workflow

Conversation

@swissspidy

@swissspidy swissspidy commented Jul 21, 2026

Copy link
Copy Markdown
Member

Follow-up to #1083

Summary by CodeRabbit

  • Chores
    • Updated the framework update workflow to automatically use the repository’s default branch as the PR base when creating or editing pull requests.
    • Improved detection of existing open pull requests for the framework update branch using an API-based lookup, reducing duplicate PRs and ensuring consistent updating and labeling.

@swissspidy
swissspidy requested a review from a team as a code owner July 21, 2026 17:07
@github-actions github-actions Bot added enhancement New feature or request scope:framework labels Jul 21, 2026
@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: aa87424c-5391-4ca2-a650-e377bf0a3c9e

📥 Commits

Reviewing files that changed from the base of the PR and between 00099de and 94693ee.

📒 Files selected for processing (1)
  • .github/workflows/update-framework.yml
🚧 Files skipped from review as they are similar to previous changes (1)
  • .github/workflows/update-framework.yml

📝 Walkthrough

Walkthrough

The framework update workflow now derives the repository’s default branch for pull request bases and uses the GitHub API to detect an existing open update-framework pull request.

Changes

Framework update workflow

Layer / File(s) Summary
Pull request detection and branch targeting
.github/workflows/update-framework.yml
The workflow derives DEFAULT_BRANCH, filters open matching pull requests through gh api, extracts the first pull request number, and uses the default branch as the base when creating or editing the pull request.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title points to adding a --json arg, but the workflow change actually switches PR lookup to gh api/jq and base-branch handling. Rename it to reflect the actual change, e.g. 'Fix update-framework workflow PR lookup and base branch handling.'
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/update-framework-workflow

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/update-framework.yml:
- Line 76: Update the PR_NUMBER lookup in the workflow to scope results to the
repository’s default branch using --base "${{
github.event.repository.default_branch }}" and extract only the first matching
number with --jq '.[0].number // empty', preserving the existing
update-framework head and open-state filters.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 609b1119-a232-4830-bda4-9786ec2030b6

📥 Commits

Reviewing files that changed from the base of the PR and between 284528f and 64d25a6.

📒 Files selected for processing (1)
  • .github/workflows/update-framework.yml

Comment thread .github/workflows/update-framework.yml Outdated

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/update-framework.yml:
- Line 76: Update the update-framework workflow’s gh pr list/create/edit
commands to avoid direct interpolation of github.event.repository.default_branch
in Bash: expose the value through an environment variable such as DEFAULT_BRANCH
and reference it as "$DEFAULT_BRANCH" in each command, preserving the existing
pull-request behavior.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 8e00bf78-b8d3-4c6e-b387-7e5f4777cf29

📥 Commits

Reviewing files that changed from the base of the PR and between 64d25a6 and 00099de.

📒 Files selected for processing (1)
  • .github/workflows/update-framework.yml

Comment thread .github/workflows/update-framework.yml Outdated
@coderabbitai coderabbitai Bot mentioned this pull request Jul 21, 2026
@swissspidy
swissspidy merged commit 727e898 into main Jul 21, 2026
64 checks passed
@swissspidy
swissspidy deleted the fix/update-framework-workflow branch July 21, 2026 17:20
@swissspidy swissspidy added scope:testing Related to testing and removed scope:framework labels Jul 21, 2026
@coderabbitai coderabbitai Bot mentioned this pull request Jul 21, 2026
@codecov

codecov Bot commented Jul 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request scope:testing Related to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant