Fix update-framework workflow: Add --json arg#1084
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe framework update workflow now derives the repository’s default branch for pull request bases and uses the GitHub API to detect an existing open ChangesFramework update workflow
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/update-framework.yml:
- Line 76: Update the PR_NUMBER lookup in the workflow to scope results to the
repository’s default branch using --base "${{
github.event.repository.default_branch }}" and extract only the first matching
number with --jq '.[0].number // empty', preserving the existing
update-framework head and open-state filters.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 609b1119-a232-4830-bda4-9786ec2030b6
📒 Files selected for processing (1)
.github/workflows/update-framework.yml
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/update-framework.yml:
- Line 76: Update the update-framework workflow’s gh pr list/create/edit
commands to avoid direct interpolation of github.event.repository.default_branch
in Bash: expose the value through an environment variable such as DEFAULT_BRANCH
and reference it as "$DEFAULT_BRANCH" in each command, preserving the existing
pull-request behavior.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 8e00bf78-b8d3-4c6e-b387-7e5f4777cf29
📒 Files selected for processing (1)
.github/workflows/update-framework.yml
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Follow-up to #1083
Summary by CodeRabbit