chore(lint): enable clippy::todo#90
Merged
Merged
Conversation
Adds `todo = "deny"` to [lints.clippy] in Cargo.toml, preventing `todo!()` placeholders from reaching production code. Also fixes pre-existing pedantic violations surfaced by running `cargo clippy --all-targets`: - Four `map_unwrap_or` violations: replace `.map(f).unwrap_or(false)` with the idiomatic `.is_ok_and(f)`. - Twelve `duration_suboptimal_units` violations in test code: replace `Duration::from_secs(N)` with `from_hours`/`from_mins` equivalents.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enables
clippy::todo = "deny"in[lints.clippy], preventingtodo!()placeholders from reaching production code. This follows the same pattern as the existingdbg_macro = "deny"lint — both catch development-only constructs that cause runtime panics if accidentally shipped.Also fixes pre-existing
pedanticviolations so thatcargo clippy --all-targetspasses cleanly:map_unwrap_or:.map(f).unwrap_or(false)→.is_ok_and(f)duration_suboptimal_unitsin test code:Duration::from_secs(N)→from_hours/from_minsequivalentsCloses #89