Fix wolfSSHD_ConfigCopy and wolfSSHD_ConfigFree#931
Merged
ejohnstown merged 1 commit intowolfSSL:masterfrom Apr 17, 2026
Merged
Fix wolfSSHD_ConfigCopy and wolfSSHD_ConfigFree#931ejohnstown merged 1 commit intowolfSSL:masterfrom
ejohnstown merged 1 commit intowolfSSL:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes wolfSSHD configuration lifetime bugs where Match-triggered config copies were dropping several string fields and config teardown was not freeing all owned strings, leading to NULL values and leaks in per-Match nodes.
Changes:
- Copy additional config string fields in
wolfSSHD_ConfigCopy()(hostCertFile,pidFile,userCAKeysFile,forceCmd). - Free additional config string fields in
wolfSSHD_ConfigFree()(userCAKeysFile,forceCmd) alongside existing frees.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
JacobBarthelmeh
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wolfSSHD_ConfigCopy() copies 8 string fields (banner, chrootDir, ciphers, hostKeyFile, hostKeyAlgos, kekAlgos, listenAddress, authKeysFile) but omits 4 others that exist on the WOLFSSHD_CONFIG struct: hostCertFile, pidFile, userCAKeysFile, and forceCmd. When a Match block triggers a config copy, these fields are silently lost, resulting in NULL pointers where valid strings are expected. Separately, wolfSSHD_ConfigFree() frees hostCertFile and pidFile but omits userCAKeysFile and forceCmd.
This PR fixes both of them and adds the regress tests.