Skip to content

Fenrir fixes#559

Draft
embhorn wants to merge 4 commits into
wolfSSL:masterfrom
embhorn:fenrir_fixes
Draft

Fenrir fixes#559
embhorn wants to merge 4 commits into
wolfSSL:masterfrom
embhorn:fenrir_fixes

Conversation

@embhorn

@embhorn embhorn commented Jul 6, 2026

Copy link
Copy Markdown
Member
  • Fix f-3627: test BrokerBufCompare length-fold auth backstop
  • Fix f-2359: preserve v5 SUBSCRIBE options through encode/decode
  • Fix f-3394: scrub CONNECT credentials from broker rx_buf after auth
  • Fix f-6656: scrub v5 CONNACK auth data from client rx_buf

@embhorn embhorn self-assigned this Jul 6, 2026
Copilot AI review requested due to automatic review settings July 6, 2026 15:06

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the broker CONNECT authentication test suite to better cover a constant-time credential comparison edge case and to align comments with the broker’s actual CONNACK return code for bad credentials.

Changes:

  • Corrects auth-failure CONNACK code references in existing tests/comments to 0x04 (Bad user name or password).
  • Adds a new mutation-guard test that fails if the length-fold backstop in BrokerBufCompare is removed (repeating-byte, different-length username case).
  • Registers the new test in the broker auth test runner.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants