Fenrir fixes#559
Draft
embhorn wants to merge 4 commits into
Draft
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the broker CONNECT authentication test suite to better cover a constant-time credential comparison edge case and to align comments with the broker’s actual CONNACK return code for bad credentials.
Changes:
- Corrects auth-failure CONNACK code references in existing tests/comments to
0x04(Bad user name or password). - Adds a new mutation-guard test that fails if the length-fold backstop in
BrokerBufCompareis removed (repeating-byte, different-length username case). - Registers the new test in the broker auth test runner.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.