Skip to content

Refactor and add CMIS mode support #NE-1208 State Done#9

Open
loulecrivain wants to merge 32 commits into
mainfrom
feature/refactor-and-cmis-mode
Open

Refactor and add CMIS mode support #NE-1208 State Done#9
loulecrivain wants to merge 32 commits into
mainfrom
feature/refactor-and-cmis-mode

Conversation

@loulecrivain

@loulecrivain loulecrivain commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

new user features:

  • support for a lot more fields
  • SFF8024 identifiers support for module identification
  • multi-lane support
  • CMIS support with banked pages (tested with finisar optic)
  • module reset support (tested with finisar optic)
  • module low power request support (tested with finisar optic)
  • JSON output

internal additions:

  • new strategy architecture to manage different management protocols (SFF8636 and CMIS). module state is represented by object, programming intents are communicated through modification of fields (high-level API).
  • documentation on DWDM standards
  • tests for INT16 read/write
  • page write through binary diff iterator

changes:

  • DWDM grid programming overhauled with generic support for all grid modes
  • manufacturers can now use / re-use out-of-standard custom pages
  • changed default verbosity / logging level to terse

removed:

  • deleted old architecture
  • deleted old DWDM grid
  • dropped high-power mode (since I cannot verify re-implem, we do not have sff8636 c band programmables at hand)

@loulecrivain loulecrivain force-pushed the feature/refactor-and-cmis-mode branch from 967ce1e to 3bd4584 Compare June 15, 2026 16:59
@loulecrivain loulecrivain force-pushed the feature/refactor-and-cmis-mode branch from 3bd4584 to 1ffdd3d Compare June 15, 2026 17:45
@loulecrivain loulecrivain force-pushed the feature/refactor-and-cmis-mode branch from d8e0097 to 1fedb1c Compare June 24, 2026 14:47
@loulecrivain loulecrivain marked this pull request as ready for review June 24, 2026 16:23
@loulecrivain loulecrivain changed the title Refactor and add CMIS mode support Refactor and add CMIS mode support #NE-1208 State Done Jun 25, 2026
@loulecrivain

Copy link
Copy Markdown
Contributor Author

ready for review! cc @johannwagner

@johannwagner johannwagner left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two nitpicks:

We should run the tests in the CI.
We should not drop high-power mode, even if you cannot verify it at the current point in time.

@loulecrivain

Copy link
Copy Markdown
Contributor Author

ok, will take care of it tomorrow and ping you when its done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants