Refactor and add CMIS mode support #NE-1208 State Done#9
Open
loulecrivain wants to merge 32 commits into
Open
Conversation
was mistakenly included as common between protocols, but doesnt exist in sff8636 as its not standard and has only been backported by a few manufacturers
+ delete write actions - will be reimplemented afterwards
967ce1e to
3bd4584
Compare
3bd4584 to
1ffdd3d
Compare
d8e0097 to
1fedb1c
Compare
Contributor
Author
|
ready for review! cc @johannwagner |
johannwagner
approved these changes
Jun 29, 2026
johannwagner
left a comment
Contributor
There was a problem hiding this comment.
Two nitpicks:
We should run the tests in the CI.
We should not drop high-power mode, even if you cannot verify it at the current point in time.
Contributor
Author
|
ok, will take care of it tomorrow and ping you when its done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
new user features:
internal additions:
changes:
removed: