Fix concourse SBOM jobs#5264
Merged
Merged
Conversation
If there is stderr output in the expression to get devshell_names, these were cluttered. Fix that by keeping the streams separate.
Same reason
6f935fc to
50f3371
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes Concourse SBOM generation job scripts by preventing Nix warnings on stderr from being merged into stdout, which previously polluted the parsed devShell/image name lists (and could also drop lines via grep -v warning).
Changes:
- Remove
2>&1 | grep -v warningfromnix evalcalls that feedmapfile, keepingstdoutstrictly to the intended newline-separated names. - Add an internal changelog entry describing the CI/SBOM job fix.
Reviewed changes
Copilot reviewed 1 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
hack/bin/create-nix-docker-image-sboms.sh |
Stops merging/filtering stderr during image name discovery for SBOM generation. |
hack/bin/create-nix-devshell-sbom.sh |
Stops merging/filtering stderr during devShell name discovery for SBOM generation. |
changelog.d/5-internal/fix-concourse-sbom-jobs |
Documents the SBOM job/script fix in the internal changelog. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
blackheaven
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2>&1 | grep -v warningmergedstderrintostdout, mixing nix warnings into themapfileexpression. Result: devShell/image name list polluted with non-name lines fromstderr.Drop the redirect so
stdoutcarries only names andstderrstays separate.This PR fixes the related jobs on CI and was tested there.
Ticket: https://wearezeta.atlassian.net/browse/WPB-26357
Checklist
changelog.d