fix(routines): resolve local timezone shift bug on naive dates#1251
Open
Marcelluxx wants to merge 2 commits into
Open
fix(routines): resolve local timezone shift bug on naive dates#1251Marcelluxx wants to merge 2 commits into
Marcelluxx wants to merge 2 commits into
Conversation
API returns naive date strings (e.g., 'YYYY-MM-DD') representing routine start and end dates. When parsed and formatted locally, negative UTC offset browser timezones shift the date backward by one day (e.g., formatting UTC midnight as the previous day in local browser time). To fix this, we: 1. Implemented 'formatNaiveDate' in 'date.ts' to format date strings and standard Date objects timezone-agnostically using 'timeZone: UTC'. 2. Replaced 'dateToLocale' calls with 'formatNaiveDate' in routine detail, template detail, and overview screens. 3. Added exhaustive unit test coverage in 'date.test.ts' verifying parsing, month boundaries, Date object support, and invalid/fallback inputs.
| return ''; | ||
| } | ||
| utcDate = date; | ||
| } else if (typeof date === 'string') { |
Member
There was a problem hiding this comment.
note that at the moment (and probably in the future as well), we will not reach this branch as all objects convert the DateTime-String into an object. I think we should simplify this part of the helper and remove this section till the need arises.
Author
There was a problem hiding this comment.
Agreed! The data layer already ensures everything is normalized to standard Date objects, so we don't need to parse strings here. I've simplified the utility and updated the test suite.
Thanks for the feedback!
…jects Per PR review feedback, removed string parsing and regex logic from formatNaiveDate as all dates are normalized to Date objects by the data layer. Updated corresponding unit tests in date.test.ts to use Date objects.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
API returns naive date strings (e.g., 'YYYY-MM-DD') representing routine start and end dates. When parsed and formatted locally, negative UTC offset browser timezones shift the date backward by one day (e.g., formatting UTC midnight as the previous day in local browser time).
Proposed Changes
formatNaiveDateindate.tsto format date strings and standard Date objects timezone-agnostically usingtimeZone: UTC.dateToLocalecalls withformatNaiveDatein routine detail, template detail, and overview screens.date.test.tsverifying parsing, month boundaries, Date object support, and invalid/fallback inputs.Related Issue(s)
Closes wger-project/wger#2334
Please check that the PR fulfills these requirements