Fix CI deploy gate + Clear-formatting icon discoverability#5
Merged
Conversation
deploy.yml's "Lint & Typecheck" job (tsc -b) failed on 5 TS2345 errors in webhook-dispatch.test.ts — a vi.fn() mock passed where the inline test's `fetchFn: typeof fetch` param is expected — which skipped the Deploy job, so pushes to main never auto-deployed. Cast the mock at the 5 call sites (`mockFetch as unknown as typeof fetch`); .mock assertions keep the Mock type. Verified: build packages + `tsc -b` → exit 0; 29 tests green. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…tton (F150) The Clear-formatting button rendered but its abstract inline-SVG eraser was hard to spot in the toolbar. Swap to Lucide's standard RemoveFormatting icon — the universally recognised "clear formatting" symbol — so editors can find it (sits right after superscript/subscript, before the separator). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes:
1. Unblock auto-deploy (
deploy.yml)The "Lint & Typecheck" job (
tsc -b) was failing on 5TS2345errors inwebhook-dispatch.test.ts(avi.fn()mock passed where the inline test'sfetchFn: typeof fetchparam is expected) → the Deploy job was skipped on every push to main (auto-deploy silently broken; prod shipped only via manualflyctl deploy). Cast the mock at the 5 call sites. Verified: build packages +tsc -b→ exit 0; 29 tests green. This PR merging + auto-deploying IS the end-to-end proof.2. Clear-formatting icon discoverability (F150)
The Clear-formatting toolbar button rendered but its abstract inline-SVG was hard to spot. Swapped to Lucide's standard
RemoveFormattingicon (the universal "clear formatting" symbol). Sits right after superscript/subscript, before the separator.🤖 Generated with Claude Code