feat: return static on Subscription::create()#453
Merged
Minishlink merged 1 commit intoMay 28, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
Subscription::create()returnsself, despite the class not beingfinal.This PR changes the return type to
static, so child classes can be created using the method.I ran into this when I extended the class to add some custom serialization/deserialization to fit within our application.
I added the
consistent-constructorannotations to prevent problems with child classes overriding the constructor. Alternatively, the constructor could be madefinal, but I feel this is preferable, leaving more room to the user while notifying static-analysis tools of the risks.