warpui_core: fix StoredView missing child_view_ids (clippy CI failure)#12845
Draft
warp-dev-github-integration[bot] wants to merge 2 commits into
Draft
warpui_core: fix StoredView missing child_view_ids (clippy CI failure)#12845warp-dev-github-integration[bot] wants to merge 2 commits into
warp-dev-github-integration[bot] wants to merge 2 commits into
Conversation
…, event_handler) Adds the concrete TuiElement implementors the TUI views compose: TuiText, TuiColumn, TuiContainer, TuiChildView, and TuiEventHandler (each with its own tests), and wires them into elements/tui/mod.rs. TuiChildView consumes the seam (render_tui_view + TuiEventContext::set_origin_view) added in the prior slice. Co-Authored-By: Oz <oz-agent@warp.dev>
The StoredView enum delegates the neutral AnyView hooks to its Gui/Tui variants, but child_view_ids was missing. collect_transferable_subtree calls view.child_view_ids(self) on a &StoredView, which failed to compile (E0599: no method named child_view_ids) and broke the Formatting + Clippy CI jobs. Add the inherent delegating method, returning the GUI view's children and an empty vec for TUI views (which have no child views), matching the existing delegation pattern. Co-Authored-By: Oz <oz-agent@warp.dev>
6 tasks
zachbai
force-pushed
the
zb/tui-backend/03b-tui-elements
branch
from
5836b37 to
0220c8b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the
Formatting + ClippyCI failures on PR #12634 (zb/tui-backend/03b-tui-elements).That PR replaced the per-window
Box<dyn AnyView>storage with aStoredViewenum (Gui/Tuibehind thetuifeature) whose inherent methods delegate the neutralAnyViewhooks. Thechild_view_idshook was missed, butAppContext::collect_transferable_subtreecallsview.child_view_ids(self)on a&StoredView, producing a hard compile error:This broke every
cargo clippyjob (Windows, wasm, etc.).Fix
Add the missing inherent
StoredView::child_view_idsdelegating method:Gui→ delegates to the GUI view'schild_view_ids(app).Tui→ returns an emptyVec(TUI views have no child views), matching the existing TUI no-op delegation arms.Validation
cargo check -p warpui_corecargo clippy -p warpui_core --features tui -- -D warningscargo fmt -p warpui_core -- --checkBase branch
This PR targets
zb/tui-backend/03b-tui-elementsso the fix lands in PR #12634.Conversation: https://staging.warp.dev/conversation/3c47ff74-808e-41cc-9573-c2147686ad00
Run: https://oz.staging.warp.dev/runs/019ee255-931a-7e25-ba5e-5375fce95c3d
This PR was generated with Oz.