Route bundled skills through active Agent Mode host#12418
Conversation
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
There was a problem hiding this comment.
Overview
This PR routes Agent Mode bundled-skill listing and read_skill resolution through the active session's skill origin so local sessions use local bundles, connected remote sessions use their host-specific remote catalog, and unavailable remote sessions do not fall back to client-local bundled content. I did not find correctness or security issues in the changed diff.
Concerns
- This is a user-facing Agent Mode behavior change, but the PR description does not include screenshots or a screen recording demonstrating the remote bundled-skill listing/read_skill behavior working end to end. For this user-facing change, please include screenshots or a short recording; if a local desktop is not available, capture it from a coding agent that supports computer use and attach it to the PR.
Verdict
Found: 0 critical, 1 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
240103d to
b2e6153
Compare
c5b079b to
a1eed9a
Compare
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
a1eed9a to
1eb5e42
Compare
9c4543a to
9632faf
Compare
1eb5e42 to
5e94bc2
Compare
5e94bc2 to
6563f57
Compare
Co-Authored-By: Oz <oz-agent@warp.dev>
9632faf to
2afaa74
Compare
6563f57 to
e9aeeff
Compare

Description
Routes Agent Mode bundled-skill listing,
read_skillresolution, and slash-command skill invocation through the active session's bundled-skill catalog. Local sessions continue using the local catalog, while connected remote sessions use the ready catalog for their exactHostId.The Agent input context passes the active session's
SkillPathOrigininto skill listing, andReadSkillExecutorreceivesActiveSessionso bundled IDs resolve from the same selected host catalog. Slash-command invocations (/skill-name) resolve through a newBlocklistAIController::skill_path_originaccessor backed by the same active session, so remote sessions embed host-rendered content instead of client-local paths. Remote sessions whose host identity/catalog is unavailable return no bundled skills and do not fall back to client-local bundled content — bothread_skilland the slash-command toast surface "Bundled skills are not available on this remote session". Existing path-based skill behavior remains unchanged.This is the third PR in the stack:
BundledSkillabstraction.read_skill, and slash-command invocation.Linked Issue
ready-to-specorready-to-implement.Testing
cargo check -p warp --all-targetspasses cleanly (including removal of the now-unusedBundledSkills::localaccessor); tests, formatters, and Clippy were not run per request../script/runAgent Mode
CHANGELOG-NONE
Co-Authored-By: Oz oz-agent@warp.dev